Skip to content

Commit 802c1d5

Browse files
Nemo157Nemo157
committed
Add test cases for suggestions with unsafe operations contained inside macros
1 parent 8f3e876 commit 802c1d5

4 files changed

+100
-11
lines changed

‎tests/ui/unsafe/auxiliary/external_unsafe_macro.rs

+4
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
pub unsafe fn unsf() {}
2+
3+
#[macro_export]
4+
macro_rules! unsafe_macro { () => ($crate::unsf()) }

‎tests/ui/unsafe/wrapping-unsafe-block-sugg.fixed

+28
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,10 @@
11
// run-rustfix
2+
// aux-build:external_unsafe_macro.rs
23

34
#![deny(unsafe_op_in_unsafe_fn)] //~ NOTE
45

6+
extern crate external_unsafe_macro;
7+
58
unsafe fn unsf() {}
69

710
pub unsafe fn foo() { unsafe {
@@ -35,4 +38,29 @@ pub unsafe fn baz() -> i32 { unsafe {
3538
//~| NOTE
3639
}}
3740

41+
macro_rules! unsafe_macro { () => (unsf()) }
42+
//~^ ERROR call to unsafe function is unsafe
43+
//~| NOTE
44+
//~| NOTE
45+
//~| ERROR call to unsafe function is unsafe
46+
//~| NOTE
47+
//~| NOTE
48+
49+
pub unsafe fn unsafe_in_macro() { unsafe {
50+
//~^ NOTE an unsafe function restricts its caller, but its body is safe by default
51+
unsafe_macro!();
52+
//~^ NOTE
53+
//~| NOTE
54+
unsafe_macro!();
55+
//~^ NOTE
56+
//~| NOTE
57+
}}
58+
59+
pub unsafe fn unsafe_in_external_macro() {
60+
// FIXME: https://github.com/rust-lang/rust/issues/112504
61+
// FIXME: ~^ NOTE an unsafe function restricts its caller, but its body is safe by default
62+
external_unsafe_macro::unsafe_macro!();
63+
external_unsafe_macro::unsafe_macro!();
64+
}
65+
3866
fn main() {}

‎tests/ui/unsafe/wrapping-unsafe-block-sugg.rs

+28
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,10 @@
11
// run-rustfix
2+
// aux-build:external_unsafe_macro.rs
23

34
#![deny(unsafe_op_in_unsafe_fn)] //~ NOTE
45

6+
extern crate external_unsafe_macro;
7+
58
unsafe fn unsf() {}
69

710
pub unsafe fn foo() {
@@ -35,4 +38,29 @@ pub unsafe fn baz() -> i32 {
3538
//~| NOTE
3639
}
3740

41+
macro_rules! unsafe_macro { () => (unsf()) }
42+
//~^ ERROR call to unsafe function is unsafe
43+
//~| NOTE
44+
//~| NOTE
45+
//~| ERROR call to unsafe function is unsafe
46+
//~| NOTE
47+
//~| NOTE
48+
49+
pub unsafe fn unsafe_in_macro() {
50+
//~^ NOTE an unsafe function restricts its caller, but its body is safe by default
51+
unsafe_macro!();
52+
//~^ NOTE
53+
//~| NOTE
54+
unsafe_macro!();
55+
//~^ NOTE
56+
//~| NOTE
57+
}
58+
59+
pub unsafe fn unsafe_in_external_macro() {
60+
// FIXME: https://github.com/rust-lang/rust/issues/112504
61+
// FIXME: ~^ NOTE an unsafe function restricts its caller, but its body is safe by default
62+
external_unsafe_macro::unsafe_macro!();
63+
external_unsafe_macro::unsafe_macro!();
64+
}
65+
3866
fn main() {}

‎tests/ui/unsafe/wrapping-unsafe-block-sugg.stderr

+40-11
Original file line numberDiff line numberDiff line change
@@ -1,70 +1,99 @@
11
error: call to unsafe function is unsafe and requires unsafe block (error E0133)
2-
--> $DIR/wrapping-unsafe-block-sugg.rs:9:5
2+
--> $DIR/wrapping-unsafe-block-sugg.rs:12:5
33
|
44
LL | unsf();
55
| ^^^^^^ call to unsafe function
66
|
77
= note: consult the function's documentation for information on how to avoid undefined behavior
88
note: an unsafe function restricts its caller, but its body is safe by default
9-
--> $DIR/wrapping-unsafe-block-sugg.rs:7:1
9+
--> $DIR/wrapping-unsafe-block-sugg.rs:10:1
1010
|
1111
LL | pub unsafe fn foo() {
1212
| ^^^^^^^^^^^^^^^^^^^
1313
note: the lint level is defined here
14-
--> $DIR/wrapping-unsafe-block-sugg.rs:3:9
14+
--> $DIR/wrapping-unsafe-block-sugg.rs:4:9
1515
|
1616
LL | #![deny(unsafe_op_in_unsafe_fn)]
1717
| ^^^^^^^^^^^^^^^^^^^^^^
1818

1919
error: call to unsafe function is unsafe and requires unsafe block (error E0133)
20-
--> $DIR/wrapping-unsafe-block-sugg.rs:12:5
20+
--> $DIR/wrapping-unsafe-block-sugg.rs:15:5
2121
|
2222
LL | unsf();
2323
| ^^^^^^ call to unsafe function
2424
|
2525
= note: consult the function's documentation for information on how to avoid undefined behavior
2626

2727
error: dereference of raw pointer is unsafe and requires unsafe block (error E0133)
28-
--> $DIR/wrapping-unsafe-block-sugg.rs:19:13
28+
--> $DIR/wrapping-unsafe-block-sugg.rs:22:13
2929
|
3030
LL | let y = *x;
3131
| ^^ dereference of raw pointer
3232
|
3333
= note: raw pointers may be null, dangling or unaligned; they can violate aliasing rules and cause data races: all of these are undefined behavior
3434
note: an unsafe function restricts its caller, but its body is safe by default
35-
--> $DIR/wrapping-unsafe-block-sugg.rs:17:1
35+
--> $DIR/wrapping-unsafe-block-sugg.rs:20:1
3636
|
3737
LL | pub unsafe fn bar(x: *const i32) -> i32 {
3838
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
3939

4040
error: dereference of raw pointer is unsafe and requires unsafe block (error E0133)
41-
--> $DIR/wrapping-unsafe-block-sugg.rs:22:9
41+
--> $DIR/wrapping-unsafe-block-sugg.rs:25:9
4242
|
4343
LL | y + *x
4444
| ^^ dereference of raw pointer
4545
|
4646
= note: raw pointers may be null, dangling or unaligned; they can violate aliasing rules and cause data races: all of these are undefined behavior
4747

4848
error: use of mutable static is unsafe and requires unsafe block (error E0133)
49-
--> $DIR/wrapping-unsafe-block-sugg.rs:30:13
49+
--> $DIR/wrapping-unsafe-block-sugg.rs:33:13
5050
|
5151
LL | let y = BAZ;
5252
| ^^^ use of mutable static
5353
|
5454
= note: mutable statics can be mutated by multiple threads: aliasing violations or data races will cause undefined behavior
5555
note: an unsafe function restricts its caller, but its body is safe by default
56-
--> $DIR/wrapping-unsafe-block-sugg.rs:28:1
56+
--> $DIR/wrapping-unsafe-block-sugg.rs:31:1
5757
|
5858
LL | pub unsafe fn baz() -> i32 {
5959
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
6060

6161
error: use of mutable static is unsafe and requires unsafe block (error E0133)
62-
--> $DIR/wrapping-unsafe-block-sugg.rs:33:9
62+
--> $DIR/wrapping-unsafe-block-sugg.rs:36:9
6363
|
6464
LL | y + BAZ
6565
| ^^^ use of mutable static
6666
|
6767
= note: mutable statics can be mutated by multiple threads: aliasing violations or data races will cause undefined behavior
6868

69-
error: aborting due to 6 previous errors
69+
error: call to unsafe function is unsafe and requires unsafe block (error E0133)
70+
--> $DIR/wrapping-unsafe-block-sugg.rs:41:36
71+
|
72+
LL | macro_rules! unsafe_macro { () => (unsf()) }
73+
| ^^^^^^ call to unsafe function
74+
...
75+
LL | unsafe_macro!();
76+
| --------------- in this macro invocation
77+
|
78+
= note: consult the function's documentation for information on how to avoid undefined behavior
79+
note: an unsafe function restricts its caller, but its body is safe by default
80+
--> $DIR/wrapping-unsafe-block-sugg.rs:49:1
81+
|
82+
LL | pub unsafe fn unsafe_in_macro() {
83+
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
84+
= note: this error originates in the macro `unsafe_macro` (in Nightly builds, run with -Z macro-backtrace for more info)
85+
86+
error: call to unsafe function is unsafe and requires unsafe block (error E0133)
87+
--> $DIR/wrapping-unsafe-block-sugg.rs:41:36
88+
|
89+
LL | macro_rules! unsafe_macro { () => (unsf()) }
90+
| ^^^^^^ call to unsafe function
91+
...
92+
LL | unsafe_macro!();
93+
| --------------- in this macro invocation
94+
|
95+
= note: consult the function's documentation for information on how to avoid undefined behavior
96+
= note: this error originates in the macro `unsafe_macro` (in Nightly builds, run with -Z macro-backtrace for more info)
97+
98+
error: aborting due to 8 previous errors
7099

0 commit comments

Comments
 (0)