Skip to content

Commit 827f656

Browse files
Enable incremental independent of stage
Previously we'd only do so for stage 0 but with keep-stage improvements it seems likely that we'll see more developers working in the stage 1, so we should allow enabling incremental for them. Ideally, the check we probably want is to only enable incremental for the last compiler build scheduled, but there's no good way to do so today. Just enabling incremental in all stages should be sufficient; we may be doing extra work that's needles -- compiling incrementally something that will never be recompiled in-place -- but that should be sufficiently unlikely (i.e., users either don't care or won't be compiling the compiler twice).
1 parent 3d5753f commit 827f656

File tree

1 file changed

+1
-4
lines changed

1 file changed

+1
-4
lines changed

src/bootstrap/builder.rs

+1-4
Original file line numberDiff line numberDiff line change
@@ -903,10 +903,7 @@ impl<'a> Builder<'a> {
903903
.env("RUSTC_SNAPSHOT_LIBDIR", self.rustc_libdir(compiler));
904904
}
905905

906-
// Ignore incremental modes except for stage0, since we're
907-
// not guaranteeing correctness across builds if the compiler
908-
// is changing under your feet.`
909-
if self.config.incremental && compiler.stage == 0 {
906+
if self.config.incremental {
910907
cargo.env("CARGO_INCREMENTAL", "1");
911908
}
912909

0 commit comments

Comments
 (0)