Skip to content

Commit

Permalink
Address review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
petrochenkov committed Apr 13, 2020
1 parent 57870ea commit 8392e47
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 4 deletions.
3 changes: 0 additions & 3 deletions src/librustc_target/spec/msvc_base.rs
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,6 @@ pub fn opts() -> TargetOptions {
link_env: vec![("VSLANG".to_string(), "1033".to_string())],
lld_flavor: LldFlavor::Link,
pre_link_args,
// UEFI mirrors the calling-conventions used on windows. In case of x86-64 and i686 this
// means small structs will be returned as int. This shouldn't matter much, since the
// restrictions placed by the UEFI specifications forbid any ABI to return structures.
abi_return_struct_as_int: true,
emit_debug_gdb_scripts: false,

Expand Down
2 changes: 1 addition & 1 deletion src/librustc_target/spec/windows_uwp_gnu_base.rs
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ pub fn opts() -> TargetOptions {
],
);

// FIXME: Should UWP target be updated for the exception machinery changes from #67502?
// FIXME: This should be updated for the exception machinery changes from #67502.
let mut late_link_args = LinkArgs::new();
let late_link_args_dynamic = LinkArgs::new();
let late_link_args_static = LinkArgs::new();
Expand Down

0 comments on commit 8392e47

Please sign in to comment.