Use to_ne_bytes for converting IPv4Address to octets

JakubOnderka · web-flow · commit 87f5a98a5d8f · 2019-01-18T19:08:31.000+01:00
It is easier and it should be also faster, because `to_ne_bytes` just calls `mem::transmute`.
diff --git a/src/libstd/net/ip.rs b/src/libstd/net/ip.rs
@@ -393,8 +393,7 @@ impl Ipv4Addr {
     /// ```
     #[stable(feature = "rust1", since = "1.0.0")]
     pub fn octets(&self) -> [u8; 4] {
-        let bits = u32::from_be(self.inner.s_addr);
-        [(bits >> 24) as u8, (bits >> 16) as u8, (bits >> 8) as u8, bits as u8]
+        self.inner.s_addr.to_ne_bytes()
     }
 
     /// Returns [`true`] for the special 'unspecified' address (0.0.0.0).

Original file line number	Diff line number	Diff line change
`@@ -393,8 +393,7 @@ impl Ipv4Addr {`
`393`	`393`	/// ```
`394`	`394`	`#[stable(feature = "rust1", since = "1.0.0")]`
`395`	`395`	`pub fn octets(&self) -> [u8; 4] {`
`396`		`- let bits = u32::from_be(self.inner.s_addr);`
`397`		`- [(bits >> 24) as u8, (bits >> 16) as u8, (bits >> 8) as u8, bits as u8]`
	`396`	`+ self.inner.s_addr.to_ne_bytes()`
`398`	`397`	`}`
`399`	`398`
`400`	`399`	/// Returns [`true`] for the special 'unspecified' address (0.0.0.0).