Rollup merge of #123825 - saethlin:report-nounwind-panics, r=petroche…

…nkov

Call the panic hook for non-unwind panics in proc-macros

As I suggested in #123286 (comment).

If a proc macro causes a non-unwinding panic, `proc_macro` isn't able to catch the unwind and report the panic as a compile error by passing control back to the compiler. Our only chance to produce any diagnostic is the panic hook, so we should call it.

This scenario has already existed, but has become a lot more interesting now that we're adding more UB-detecting panics to the standard library, and such panics do not unwind.

library/proc_macro/src/bridge/client.rs

@@ -283,7 +283,11 @@ fn maybe_install_panic_hook(force_show_panics: bool) {
  HIDE_PANICS_DURING_EXPANSION.call_once(|| {
  let prev = panic::take_hook();
  panic::set_hook(Box::new(move |info| {
- if force_show_panics || !is_available() {
+ // We normally report panics by catching unwinds and passing the payload from the
+ // unwind back to the compiler, but if the panic doesn't unwind we'll abort before
+ // the compiler has a chance to print an error. So we special-case PanicInfo where
+ // can_unwind is false.
+ if force_show_panics || !is_available() || !info.can_unwind() {
  prev(info)
  }
  }));

library/proc_macro/src/lib.rs

@@ -30,6 +30,7 @@
 #![feature(maybe_uninit_write_slice)]
 #![feature(negative_impls)]
 #![feature(new_uninit)]
+#![feature(panic_can_unwind)]
 #![feature(restricted_std)]
 #![feature(rustc_attrs)]
 #![feature(min_specialization)]