Rollup merge of #93600 - last-partizan:fix-junit-formatter, r=yaahc

JohnTitor · web-flow · commit 95efb2b57853 · 2022-02-03T22:20:28.000+09:00
fix: Remove extra newlines from junit output This PR fixes extra newline in junit output #93454
diff --git a/library/test/src/formatters/junit.rs b/library/test/src/formatters/junit.rs
@@ -33,7 +33,6 @@ impl<T: Write> OutputFormatter for JunitFormatter<T> {
         _shuffle_seed: Option<u64>,
     ) -> io::Result<()> {
         // We write xml header on run start
-        self.out.write_all(b"\n")?;
         self.write_message("<?xml version=\"1.0\" encoding=\"UTF-8\"?>")
     }
 
@@ -138,7 +137,7 @@ impl<T: Write> OutputFormatter for JunitFormatter<T> {
         self.write_message("</testsuite>")?;
         self.write_message("</testsuites>")?;
 
-        self.out.write_all(b"\n\n")?;
+        self.out.write_all(b"\n")?;
 
         Ok(state.failed == 0)
     }

Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,6 @@ impl<T: Write> OutputFormatter for JunitFormatter<T> {`
`33`	`33`	`_shuffle_seed: Option<u64>,`
`34`	`34`	`) -> io::Result<()> {`
`35`	`35`	`// We write xml header on run start`
`36`		`- self.out.write_all(b"\n")?;`
`37`	`36`	`self.write_message("<?xml version=\"1.0\" encoding=\"UTF-8\"?>")`
`38`	`37`	`}`
`39`	`38`
`@@ -138,7 +137,7 @@ impl<T: Write> OutputFormatter for JunitFormatter<T> {`
`138`	`137`	`self.write_message("</testsuite>")?;`
`139`	`138`	`self.write_message("</testsuites>")?;`
`140`	`139`
`141`		`- self.out.write_all(b"\n\n")?;`
	`140`	`+ self.out.write_all(b"\n")?;`
`142`	`141`
`143`	`142`	`Ok(state.failed == 0)`
`144`	`143`	`}`