Skip to content

Commit 9b7d5a8

Browse files
committed
Update the binary_asm_label message
The link pointed to a closed issue. Create a new one and point the link to it. Also add a help message to hint what change the user could make. Fixes: #127821
1 parent 9387a75 commit 9b7d5a8

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

compiler/rustc_lint/messages.ftl

+3-2
Original file line numberDiff line numberDiff line change
@@ -403,8 +403,9 @@ lint_inner_macro_attribute_unstable = inner macro attributes are unstable
403403
404404
lint_invalid_asm_label_binary = avoid using labels containing only the digits `0` and `1` in inline assembly
405405
.label = use a different label that doesn't start with `0` or `1`
406-
.note = an LLVM bug makes these labels ambiguous with a binary literal number
407-
.note = see <https://bugs.llvm.org/show_bug.cgi?id=36144> for more information
406+
.help = Start numbering with `2`
407+
.note = an LLVM bug makes these labels ambiguous with a binary literal number on x86
408+
.note = see <https://github.com/llvm/llvm-project/issues/99547> for more information
408409
409410
lint_invalid_asm_label_format_arg = avoid using named labels in inline assembly
410411
.help = only local labels of the form `<number>:` should be used in inline asm

compiler/rustc_lint/src/lints.rs

+1
Original file line numberDiff line numberDiff line change
@@ -2066,6 +2066,7 @@ pub enum InvalidAsmLabel {
20662066
missing_precise_span: bool,
20672067
},
20682068
#[diag(lint_invalid_asm_label_binary)]
2069+
#[help]
20692070
#[note]
20702071
Binary {
20712072
#[note(lint_invalid_asm_label_no_span)]

0 commit comments

Comments
 (0)