Only mark spans in incremental mode.

cjgillot · cjgillot · commit 9b82411d8f25 · 2024-07-02T21:44:38.000Z
diff --git a/compiler/rustc_resolve/src/def_collector.rs b/compiler/rustc_resolve/src/def_collector.rs
@@ -131,7 +131,9 @@ impl<'a, 'b, 'tcx> DefCollector<'a, 'b, 'tcx> {
 
 impl<'a, 'b, 'tcx> mut_visit::MutVisitor for DefCollector<'a, 'b, 'tcx> {
     fn visit_span(&mut self, span: &mut Span) {
-        *span = span.with_parent(Some(self.parent_def));
+        if self.resolver.tcx.sess.opts.incremental.is_some() {
+            *span = span.with_parent(Some(self.parent_def));
+        }
     }
 
     #[tracing::instrument(level = "trace", skip(self))]

Original file line number	Diff line number	Diff line change
`@@ -131,7 +131,9 @@ impl<'a, 'b, 'tcx> DefCollector<'a, 'b, 'tcx> {`
`131`	`131`
`132`	`132`	`impl<'a, 'b, 'tcx> mut_visit::MutVisitor for DefCollector<'a, 'b, 'tcx> {`
`133`	`133`	`fn visit_span(&mut self, span: &mut Span) {`
`134`		`- *span = span.with_parent(Some(self.parent_def));`
	`134`	`+ if self.resolver.tcx.sess.opts.incremental.is_some() {`
	`135`	`+ *span = span.with_parent(Some(self.parent_def));`
	`136`	`+ }`
`135`	`137`	`}`
`136`	`138`
`137`	`139`	`#[tracing::instrument(level = "trace", skip(self))]`