Migrate run-make/comment-section to rmake.rs

src/tools/tidy/src/allowed_run_make_makefiles.txt

@@ -11,7 +11,6 @@ run-make/c-unwind-abi-catch-panic/Makefile
 run-make/cat-and-grep-sanity-check/Makefile
 run-make/cdylib-dylib-linkage/Makefile
 run-make/cdylib-fewer-symbols/Makefile
-run-make/comment-section/Makefile
 run-make/compiler-lookup-paths-2/Makefile
 run-make/compiler-lookup-paths/Makefile
 run-make/compiler-rt-works-on-mingw/Makefile

tests/run-make/comment-section/main.rs

@@ -0,0 +1 @@
+fn main() {}

tests/run-make/comment-section/rmake.rs

@@ -0,0 +1,44 @@
+// Both GCC and Clang write by default a `.comment` section with compiler information.
+// Rustc received a similar .comment section, so this tests checks that this section
+// properly appears.
+// See https://github.com/rust-lang/rust/commit/74b8d324eb77a8f337b35dc68ac91b0c2c06debc
+
+//@ only-linux
+
+use std::path::PathBuf;
+
+use run_make_support::llvm_readobj;
+use run_make_support::rustc;
+use run_make_support::{cwd, env_var, read_dir, run_in_tmpdir};
+
+fn main() {
+    let target = env_var("TARGET");
+
+    run_in_tmpdir(|| {
+        let p = cwd();
+
+        rustc().input("main.rs").emit("link,obj").arg("-Csave-temps").target(&target).run();
+
+        // Check linked output has a `.comment` section with the expected content.
+        llvm_readobj()
+            .gnu_elf_style()
+            .section(".comment")
+            .arg(PathBuf::from(&p).join("main"))
+            .run()
+            .assert_stdout_contains("rustc version 1.");
+
+        // Check all object files (including temporary outputs) have a `.comment`
+        // section with the expected content.
+        read_dir(p, |f| {
+            if f.extension() != Some(".o".as_ref()) {
+                return;
+            }
+            llvm_readobj()
+                .gnu_elf_style()
+                .section(".comment")
+                .arg(&f)
+                .run()
+                .assert_stdout_contains("rustc version 1.");
+        });
+    })
+}