Skip to content

Commit a2c111a

Browse files
committed
mk: Get rid of redundant LIBUV_FLAGS.
1 parent 6820ed4 commit a2c111a

File tree

2 files changed

+6
-38
lines changed

2 files changed

+6
-38
lines changed

mk/platform.mk

+3-2
Original file line numberDiff line numberDiff line change
@@ -231,7 +231,7 @@ CFG_LIB_NAME_x86_64-apple-darwin=lib$(1).dylib
231231
CFG_STATIC_LIB_NAME_x86_64-apple-darwin=lib$(1).a
232232
CFG_LIB_GLOB_x86_64-apple-darwin=lib$(1)-*.dylib
233233
CFG_LIB_DSYM_GLOB_x86_64-apple-darwin=lib$(1)-*.dylib.dSYM
234-
CFG_GCCISH_CFLAGS_x86_64-apple-darwin := -Wall -Werror -g -fPIC -m64 -arch x86_64
234+
CFG_GCCISH_CFLAGS_x86_64-apple-darwin := -Wall -g -fPIC -m64 -arch x86_64
235235
CFG_GCCISH_CXXFLAGS_x86_64-apple-darwin := -fno-rtti
236236
CFG_GCCISH_LINK_FLAGS_x86_64-apple-darwin := -dynamiclib -pthread -framework CoreServices -m64
237237
CFG_GCCISH_DEF_FLAG_x86_64-apple-darwin := -Wl,-exported_symbols_list,
@@ -300,6 +300,7 @@ CFG_LDPATH_arm-linux-androideabi :=
300300
CFG_RUN_arm-linux-androideabi=
301301
CFG_RUN_TARG_arm-linux-androideabi=
302302
RUSTC_FLAGS_arm-linux-androideabi :=--android-cross-path=$(CFG_ANDROID_CROSS_PATH)
303+
RUSTC_CROSS_FLAGS_arm-linux-androideabi :=--android-cross-path=$(CFG_ANDROID_CROSS_PATH)
303304

304305
# arm-unknown-linux-gnueabihf configuration
305306
CROSS_PREFIX_arm-unknown-linux-gnueabihf=arm-linux-gnueabihf-
@@ -395,7 +396,7 @@ CFG_LIB_NAME_i686-pc-mingw32=$(1).dll
395396
CFG_STATIC_LIB_NAME_i686-pc-mingw32=$(1).lib
396397
CFG_LIB_GLOB_i686-pc-mingw32=$(1)-*.dll
397398
CFG_LIB_DSYM_GLOB_i686-pc-mingw32=$(1)-*.dylib.dSYM
398-
CFG_GCCISH_CFLAGS_i686-pc-mingw32 := -Wall -Werror -g -m32 -march=i686 -D_WIN32_WINNT=0x0600 -I$(CFG_SRC_DIR)src/etc/mingw-fix-include
399+
CFG_GCCISH_CFLAGS_i686-pc-mingw32 := -Wall -g -m32 -march=i686 -D_WIN32_WINNT=0x0600 -I$(CFG_SRC_DIR)src/etc/mingw-fix-include
399400
CFG_GCCISH_CXXFLAGS_i686-pc-mingw32 := -fno-rtti
400401
CFG_GCCISH_LINK_FLAGS_i686-pc-mingw32 := -shared -fPIC -g -m32
401402
CFG_GCCISH_DEF_FLAG_i686-pc-mingw32 :=

mk/rt.mk

+3-36
Original file line numberDiff line numberDiff line change
@@ -23,39 +23,6 @@
2323
# fit the experimental data (i.e., I was able to get the system
2424
# working under these assumptions).
2525

26-
# Hack for passing flags into LIBUV, see below.
27-
define DEF_LIBUV_FLAGS
28-
ifeq ($(HOST_$(1)), i386)
29-
ifneq (,$(findstring mingw32,$(OSTYPE_$(1))))
30-
# Don't add -fPIC since it's ignored for this target
31-
# and it will just cause the build to fail due to -Werror
32-
LIBUV_FLAGS_$(1) = -m32 -I$(S)src/etc/mingw-fix-include
33-
else
34-
LIBUV_FLAGS_$(1) = -m32 -fPIC -I$(S)src/etc/mingw-fix-include
35-
endif
36-
else ifeq ($(HOST_$(1)), x86_64)
37-
ifneq (,$(findstring mingw32,$(OSTYPE_$(1))))
38-
# Don't add -fPIC since it's ignored for this target
39-
# and it will just cause the build to fail due to -Werror
40-
LIBUV_FLAGS_$(1) = -m64
41-
else
42-
LIBUV_FLAGS_$(1) = -m64 -fPIC
43-
endif
44-
else ifeq ($(HOST_$(1)), arm)
45-
ifeq ($(OSTYPE_$(1)), apple-darwin)
46-
IOS_SDK := $(shell xcrun --show-sdk-path -sdk iphoneos 2>/dev/null)
47-
LIBUV_FLAGS_$(1) = -fPIC -std=gnu99 -I$(IOS_SDK)/usr/include -I$(IOS_SDK)/usr/include/c++/4.2.1
48-
else
49-
LIBUV_FLAGS_$(1) = -fPIC -std=gnu99
50-
endif
51-
else ifeq ($(HOST_$(1)), mips)
52-
LIBUV_FLAGS_$(1) = -fPIC -mips32r2 -msoft-float -mabi=32
53-
else
54-
LIBUV_FLAGS_$(1) = -fPIC -std=gnu99
55-
endif
56-
endef
57-
$(foreach t,$(CFG_TARGET),$(eval $(call DEF_LIBUV_FLAGS,$(t))))
58-
5926
# when we're doing a snapshot build, we intentionally degrade as many
6027
# features in libuv and the runtime as possible, to ease portability.
6128

@@ -238,15 +205,15 @@ $$(LIBUV_MAKEFILE_$(1)): $$(LIBUV_DEPS)
238205
ifdef CFG_WINDOWSY_$(1)
239206
$$(LIBUV_LIB_$(1)): $$(LIBUV_DEPS)
240207
$$(Q)$$(MAKE) -C $$(S)src/libuv -f Makefile.mingw \
241-
CC="$$(CC_$(1)) $$(CFG_GCCISH_CFLAGS_$(1)) $$(LIBUV_FLAGS_$(1)) $$(SNAP_DEFINES)" \
208+
CC="$$(CC_$(1)) $$(CFG_GCCISH_CFLAGS_$(1)) $$(SNAP_DEFINES)" \
242209
AR="$$(AR_$(1))" \
243210
V=$$(VERBOSE)
244211
$$(Q)cp $$(S)src/libuv/libuv.a $$@
245212
else
246213
$$(LIBUV_LIB_$(1)): $$(LIBUV_DEPS) $$(LIBUV_MAKEFILE_$(1))
247214
$$(Q)$$(MAKE) -C $$(@D) \
248-
CFLAGS="$$(CFG_GCCISH_CFLAGS_$(1)) $$(LIBUV_FLAGS_$(1)) $$(SNAP_DEFINES)" \
249-
LDFLAGS="$$(CFG_GCCISH_LINK_FLAGS_$(1)) $$(LIBUV_FLAGS_$(1))" \
215+
CFLAGS="$$(CFG_GCCISH_CFLAGS_$(1)) $$(SNAP_DEFINES)" \
216+
LDFLAGS="$$(CFG_GCCISH_LINK_FLAGS_$(1))" \
250217
CC="$$(CC_$(1))" \
251218
CXX="$$(CXX_$(1))" \
252219
AR="$$(AR_$(1))" \

0 commit comments

Comments
 (0)