Skip to content

Commit a8b5e5d

Browse files
matthiaskrgrmatthiaskrgr
authored
Rollup merge of #107248 - erikdesjardins:addrspace, r=oli-obk
abi: add AddressSpace field to Primitive::Pointer ...and remove it from `PointeeInfo`, which isn't meant for this. There are still various places (marked with FIXMEs) that assume all pointers have the same size and alignment. Fixing this requires parsing non-default address spaces in the data layout string (and various other changes), which will be done in a followup. (That is, if it's actually worth it to support multiple different pointer sizes. There is a lot of code that would be affected by that.) Fixes #106367 r? ``@oli-obk`` cc ``@Patryk27``
2 parents a8e8406 + adc1890 commit a8b5e5d

File tree

28 files changed

+229
-197
lines changed

28 files changed

+229
-197
lines changed

‎compiler/rustc_abi/src/lib.rs

Lines changed: 14 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -267,6 +267,9 @@ impl TargetDataLayout {
267267
["a", ref a @ ..] => dl.aggregate_align = align(a, "a")?,
268268
["f32", ref a @ ..] => dl.f32_align = align(a, "f32")?,
269269
["f64", ref a @ ..] => dl.f64_align = align(a, "f64")?,
270+
// FIXME(erikdesjardins): we should be parsing nonzero address spaces
271+
// this will require replacing TargetDataLayout::{pointer_size,pointer_align}
272+
// with e.g. `fn pointer_size_in(AddressSpace)`
270273
[p @ "p", s, ref a @ ..] | [p @ "p0", s, ref a @ ..] => {
271274
dl.pointer_size = size(s, p)?;
272275
dl.pointer_align = align(a, p)?;
@@ -861,7 +864,7 @@ pub enum Primitive {
861864
Int(Integer, bool),
862865
F32,
863866
F64,
864-
Pointer,
867+
Pointer(AddressSpace),
865868
}
866869

867870
impl Primitive {
@@ -872,7 +875,10 @@ impl Primitive {
872875
Int(i, _) => i.size(),
873876
F32 => Size::from_bits(32),
874877
F64 => Size::from_bits(64),
875-
Pointer => dl.pointer_size,
878+
// FIXME(erikdesjardins): ignoring address space is technically wrong, pointers in
879+
// different address spaces can have different sizes
880+
// (but TargetDataLayout doesn't currently parse that part of the DL string)
881+
Pointer(_) => dl.pointer_size,
876882
}
877883
}
878884

@@ -883,26 +889,12 @@ impl Primitive {
883889
Int(i, _) => i.align(dl),
884890
F32 => dl.f32_align,
885891
F64 => dl.f64_align,
886-
Pointer => dl.pointer_align,
892+
// FIXME(erikdesjardins): ignoring address space is technically wrong, pointers in
893+
// different address spaces can have different alignments
894+
// (but TargetDataLayout doesn't currently parse that part of the DL string)
895+
Pointer(_) => dl.pointer_align,
887896
}
888897
}
889-
890-
// FIXME(eddyb) remove, it's trivial thanks to `matches!`.
891-
#[inline]
892-
pub fn is_float(self) -> bool {
893-
matches!(self, F32 | F64)
894-
}
895-
896-
// FIXME(eddyb) remove, it's completely unused.
897-
#[inline]
898-
pub fn is_int(self) -> bool {
899-
matches!(self, Int(..))
900-
}
901-
902-
#[inline]
903-
pub fn is_ptr(self) -> bool {
904-
matches!(self, Pointer)
905-
}
906898
}
907899

908900
/// Inclusive wrap-around range of valid values, that is, if
@@ -1188,7 +1180,8 @@ impl FieldsShape {
11881180
/// An identifier that specifies the address space that some operation
11891181
/// should operate on. Special address spaces have an effect on code generation,
11901182
/// depending on the target and the address spaces it implements.
1191-
#[derive(Copy, Clone, Debug, PartialEq, Eq, PartialOrd, Ord)]
1183+
#[derive(Copy, Clone, Debug, PartialEq, Eq, PartialOrd, Ord, Hash)]
1184+
#[cfg_attr(feature = "nightly", derive(HashStable_Generic))]
11921185
pub struct AddressSpace(pub u32);
11931186

11941187
impl AddressSpace {
@@ -1468,7 +1461,6 @@ pub struct PointeeInfo {
14681461
pub size: Size,
14691462
pub align: Align,
14701463
pub safe: Option<PointerKind>,
1471-
pub address_space: AddressSpace,
14721464
}
14731465

14741466
/// Used in `might_permit_raw_init` to indicate the kind of initialisation

‎compiler/rustc_codegen_cranelift/src/common.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,8 @@ pub(crate) fn scalar_to_clif_type(tcx: TyCtxt<'_>, scalar: Scalar) -> Type {
3535
},
3636
Primitive::F32 => types::F32,
3737
Primitive::F64 => types::F64,
38-
Primitive::Pointer => pointer_ty(tcx),
38+
// FIXME(erikdesjardins): handle non-default addrspace ptr sizes
39+
Primitive::Pointer(_) => pointer_ty(tcx),
3940
}
4041
}
4142

‎compiler/rustc_codegen_gcc/src/builder.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -709,7 +709,7 @@ impl<'a, 'gcc, 'tcx> BuilderMethods<'a, 'tcx> for Builder<'a, 'gcc, 'tcx> {
709709
bx.range_metadata(load, vr);
710710
}
711711
}
712-
abi::Pointer if vr.start < vr.end && !vr.contains(0) => {
712+
abi::Pointer(_) if vr.start < vr.end && !vr.contains(0) => {
713713
bx.nonnull_metadata(load);
714714
}
715715
_ => {}

‎compiler/rustc_codegen_gcc/src/common.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,7 @@ impl<'gcc, 'tcx> ConstMethods<'tcx> for CodegenCx<'gcc, 'tcx> {
211211
let base_addr = self.const_bitcast(base_addr, self.usize_type);
212212
let offset = self.context.new_rvalue_from_long(self.usize_type, offset.bytes() as i64);
213213
let ptr = self.const_bitcast(base_addr + offset, ptr_type);
214-
if layout.primitive() != Pointer {
214+
if !matches!(layout.primitive(), Pointer(_)) {
215215
self.const_bitcast(ptr.dereference(None).to_rvalue(), ty)
216216
}
217217
else {

‎compiler/rustc_codegen_gcc/src/consts.rs

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -322,13 +322,16 @@ pub fn const_alloc_to_gcc<'gcc, 'tcx>(cx: &CodegenCx<'gcc, 'tcx>, alloc: ConstAl
322322
)
323323
.expect("const_alloc_to_llvm: could not read relocation pointer")
324324
as u64;
325+
326+
let address_space = cx.tcx.global_alloc(alloc_id).address_space(cx);
327+
325328
llvals.push(cx.scalar_to_backend(
326329
InterpScalar::from_pointer(
327330
interpret::Pointer::new(alloc_id, Size::from_bytes(ptr_offset)),
328331
&cx.tcx,
329332
),
330-
abi::Scalar::Initialized { value: Primitive::Pointer, valid_range: WrappingRange::full(dl.pointer_size) },
331-
cx.type_i8p(),
333+
abi::Scalar::Initialized { value: Primitive::Pointer(address_space), valid_range: WrappingRange::full(dl.pointer_size) },
334+
cx.type_i8p_ext(address_space),
332335
));
333336
next_offset = offset + pointer_size;
334337
}

‎compiler/rustc_codegen_gcc/src/type_of.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -253,7 +253,7 @@ impl<'tcx> LayoutGccExt<'tcx> for TyAndLayout<'tcx> {
253253
Int(i, false) => cx.type_from_unsigned_integer(i),
254254
F32 => cx.type_f32(),
255255
F64 => cx.type_f64(),
256-
Pointer => {
256+
Pointer(address_space) => {
257257
// If we know the alignment, pick something better than i8.
258258
let pointee =
259259
if let Some(pointee) = self.pointee_info_at(cx, offset) {
@@ -262,7 +262,7 @@ impl<'tcx> LayoutGccExt<'tcx> for TyAndLayout<'tcx> {
262262
else {
263263
cx.type_i8()
264264
};
265-
cx.type_ptr_to(pointee)
265+
cx.type_ptr_to_ext(pointee, address_space)
266266
}
267267
}
268268
}

‎compiler/rustc_codegen_llvm/src/asm.rs

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -849,14 +849,16 @@ fn dummy_output_type<'ll>(cx: &CodegenCx<'ll, '_>, reg: InlineAsmRegClass) -> &'
849849
/// Helper function to get the LLVM type for a Scalar. Pointers are returned as
850850
/// the equivalent integer type.
851851
fn llvm_asm_scalar_type<'ll>(cx: &CodegenCx<'ll, '_>, scalar: Scalar) -> &'ll Type {
852+
let dl = &cx.tcx.data_layout;
852853
match scalar.primitive() {
853854
Primitive::Int(Integer::I8, _) => cx.type_i8(),
854855
Primitive::Int(Integer::I16, _) => cx.type_i16(),
855856
Primitive::Int(Integer::I32, _) => cx.type_i32(),
856857
Primitive::Int(Integer::I64, _) => cx.type_i64(),
857858
Primitive::F32 => cx.type_f32(),
858859
Primitive::F64 => cx.type_f64(),
859-
Primitive::Pointer => cx.type_isize(),
860+
// FIXME(erikdesjardins): handle non-default addrspace ptr sizes
861+
Primitive::Pointer(_) => cx.type_from_integer(dl.ptr_sized_integer()),
860862
_ => unreachable!(),
861863
}
862864
}
@@ -868,6 +870,7 @@ fn llvm_fixup_input<'ll, 'tcx>(
868870
reg: InlineAsmRegClass,
869871
layout: &TyAndLayout<'tcx>,
870872
) -> &'ll Value {
873+
let dl = &bx.tcx.data_layout;
871874
match (reg, layout.abi) {
872875
(InlineAsmRegClass::AArch64(AArch64InlineAsmRegClass::vreg), Abi::Scalar(s)) => {
873876
if let Primitive::Int(Integer::I8, _) = s.primitive() {
@@ -881,8 +884,10 @@ fn llvm_fixup_input<'ll, 'tcx>(
881884
let elem_ty = llvm_asm_scalar_type(bx.cx, s);
882885
let count = 16 / layout.size.bytes();
883886
let vec_ty = bx.cx.type_vector(elem_ty, count);
884-
if let Primitive::Pointer = s.primitive() {
885-
value = bx.ptrtoint(value, bx.cx.type_isize());
887+
// FIXME(erikdesjardins): handle non-default addrspace ptr sizes
888+
if let Primitive::Pointer(_) = s.primitive() {
889+
let t = bx.type_from_integer(dl.ptr_sized_integer());
890+
value = bx.ptrtoint(value, t);
886891
}
887892
bx.insert_element(bx.const_undef(vec_ty), value, bx.const_i32(0))
888893
}
@@ -958,7 +963,7 @@ fn llvm_fixup_output<'ll, 'tcx>(
958963
}
959964
(InlineAsmRegClass::AArch64(AArch64InlineAsmRegClass::vreg_low16), Abi::Scalar(s)) => {
960965
value = bx.extract_element(value, bx.const_i32(0));
961-
if let Primitive::Pointer = s.primitive() {
966+
if let Primitive::Pointer(_) = s.primitive() {
962967
value = bx.inttoptr(value, layout.llvm_type(bx.cx));
963968
}
964969
value

‎compiler/rustc_codegen_llvm/src/builder.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -511,7 +511,7 @@ impl<'a, 'll, 'tcx> BuilderMethods<'a, 'tcx> for Builder<'a, 'll, 'tcx> {
511511
bx.range_metadata(load, scalar.valid_range(bx));
512512
}
513513
}
514-
abi::Pointer => {
514+
abi::Pointer(_) => {
515515
if !scalar.valid_range(bx).contains(0) {
516516
bx.nonnull_metadata(load);
517517
}

‎compiler/rustc_codegen_llvm/src/common.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -236,7 +236,7 @@ impl<'ll, 'tcx> ConstMethods<'tcx> for CodegenCx<'ll, 'tcx> {
236236
Scalar::Int(int) => {
237237
let data = int.assert_bits(layout.size(self));
238238
let llval = self.const_uint_big(self.type_ix(bitsize), data);
239-
if layout.primitive() == Pointer {
239+
if matches!(layout.primitive(), Pointer(_)) {
240240
unsafe { llvm::LLVMConstIntToPtr(llval, llty) }
241241
} else {
242242
self.const_bitcast(llval, llty)
@@ -284,7 +284,7 @@ impl<'ll, 'tcx> ConstMethods<'tcx> for CodegenCx<'ll, 'tcx> {
284284
1,
285285
)
286286
};
287-
if layout.primitive() != Pointer {
287+
if !matches!(layout.primitive(), Pointer(_)) {
288288
unsafe { llvm::LLVMConstPtrToInt(llval, llty) }
289289
} else {
290290
self.const_bitcast(llval, llty)

‎compiler/rustc_codegen_llvm/src/consts.rs

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -13,17 +13,15 @@ use rustc_codegen_ssa::traits::*;
1313
use rustc_hir::def_id::DefId;
1414
use rustc_middle::middle::codegen_fn_attrs::{CodegenFnAttrFlags, CodegenFnAttrs};
1515
use rustc_middle::mir::interpret::{
16-
read_target_uint, Allocation, ConstAllocation, ErrorHandled, GlobalAlloc, InitChunk, Pointer,
16+
read_target_uint, Allocation, ConstAllocation, ErrorHandled, InitChunk, Pointer,
1717
Scalar as InterpScalar,
1818
};
1919
use rustc_middle::mir::mono::MonoItem;
2020
use rustc_middle::ty::layout::LayoutOf;
2121
use rustc_middle::ty::{self, Instance, Ty};
2222
use rustc_middle::{bug, span_bug};
2323
use rustc_session::config::Lto;
24-
use rustc_target::abi::{
25-
AddressSpace, Align, HasDataLayout, Primitive, Scalar, Size, WrappingRange,
26-
};
24+
use rustc_target::abi::{Align, HasDataLayout, Primitive, Scalar, Size, WrappingRange};
2725
use std::ops::Range;
2826

2927
pub fn const_alloc_to_llvm<'ll>(cx: &CodegenCx<'ll, '_>, alloc: ConstAllocation<'_>) -> &'ll Value {
@@ -98,20 +96,15 @@ pub fn const_alloc_to_llvm<'ll>(cx: &CodegenCx<'ll, '_>, alloc: ConstAllocation<
9896
.expect("const_alloc_to_llvm: could not read relocation pointer")
9997
as u64;
10098

101-
let address_space = match cx.tcx.global_alloc(alloc_id) {
102-
GlobalAlloc::Function(..) => cx.data_layout().instruction_address_space,
103-
GlobalAlloc::Static(..) | GlobalAlloc::Memory(..) | GlobalAlloc::VTable(..) => {
104-
AddressSpace::DATA
105-
}
106-
};
99+
let address_space = cx.tcx.global_alloc(alloc_id).address_space(cx);
107100

108101
llvals.push(cx.scalar_to_backend(
109102
InterpScalar::from_pointer(
110103
Pointer::new(alloc_id, Size::from_bytes(ptr_offset)),
111104
&cx.tcx,
112105
),
113106
Scalar::Initialized {
114-
value: Primitive::Pointer,
107+
value: Primitive::Pointer(address_space),
115108
valid_range: WrappingRange::full(dl.pointer_size),
116109
},
117110
cx.type_i8p_ext(address_space),

‎compiler/rustc_codegen_llvm/src/debuginfo/metadata/enums/mod.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,8 @@ fn tag_base_type<'ll, 'tcx>(
122122
Primitive::Int(t, _) => t,
123123
Primitive::F32 => Integer::I32,
124124
Primitive::F64 => Integer::I64,
125-
Primitive::Pointer => {
125+
// FIXME(erikdesjardins): handle non-default addrspace ptr sizes
126+
Primitive::Pointer(_) => {
126127
// If the niche is the NULL value of a reference, then `discr_enum_ty` will be
127128
// a RawPtr. CodeView doesn't know what to do with enums whose base type is a
128129
// pointer so we fix this up to just be `usize`.

‎compiler/rustc_codegen_llvm/src/intrinsic.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,7 @@ impl<'ll, 'tcx> IntrinsicCallMethods<'tcx> for Builder<'_, 'll, 'tcx> {
149149
emit_va_arg(self, args[0], ret_ty)
150150
}
151151
}
152-
Primitive::F64 | Primitive::Pointer => {
152+
Primitive::F64 | Primitive::Pointer(_) => {
153153
emit_va_arg(self, args[0], ret_ty)
154154
}
155155
// `va_arg` should never be used with the return type f32.

‎compiler/rustc_codegen_llvm/src/type_of.rs

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ use rustc_middle::bug;
77
use rustc_middle::ty::layout::{FnAbiOf, LayoutOf, TyAndLayout};
88
use rustc_middle::ty::print::{with_no_trimmed_paths, with_no_visible_paths};
99
use rustc_middle::ty::{self, Ty, TypeVisitable};
10-
use rustc_target::abi::{Abi, AddressSpace, Align, FieldsShape};
10+
use rustc_target::abi::{Abi, Align, FieldsShape};
1111
use rustc_target::abi::{Int, Pointer, F32, F64};
1212
use rustc_target::abi::{PointeeInfo, Scalar, Size, TyAbiInterface, Variants};
1313
use smallvec::{smallvec, SmallVec};
@@ -312,14 +312,13 @@ impl<'tcx> LayoutLlvmExt<'tcx> for TyAndLayout<'tcx> {
312312
Int(i, _) => cx.type_from_integer(i),
313313
F32 => cx.type_f32(),
314314
F64 => cx.type_f64(),
315-
Pointer => {
315+
Pointer(address_space) => {
316316
// If we know the alignment, pick something better than i8.
317-
let (pointee, address_space) =
318-
if let Some(pointee) = self.pointee_info_at(cx, offset) {
319-
(cx.type_pointee_for_align(pointee.align), pointee.address_space)
320-
} else {
321-
(cx.type_i8(), AddressSpace::DATA)
322-
};
317+
let pointee = if let Some(pointee) = self.pointee_info_at(cx, offset) {
318+
cx.type_pointee_for_align(pointee.align)
319+
} else {
320+
cx.type_i8()
321+
};
323322
cx.type_ptr_to_ext(pointee, address_space)
324323
}
325324
}

‎compiler/rustc_codegen_ssa/src/mir/block.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1801,8 +1801,8 @@ impl<'a, 'tcx, Bx: BuilderMethods<'a, 'tcx>> FunctionCx<'a, 'tcx, Bx> {
18011801
match (src.layout.abi, dst.layout.abi) {
18021802
(abi::Abi::Scalar(src_scalar), abi::Abi::Scalar(dst_scalar)) => {
18031803
// HACK(eddyb) LLVM doesn't like `bitcast`s between pointers and non-pointers.
1804-
let src_is_ptr = src_scalar.primitive() == abi::Pointer;
1805-
let dst_is_ptr = dst_scalar.primitive() == abi::Pointer;
1804+
let src_is_ptr = matches!(src_scalar.primitive(), abi::Pointer(_));
1805+
let dst_is_ptr = matches!(dst_scalar.primitive(), abi::Pointer(_));
18061806
if src_is_ptr == dst_is_ptr {
18071807
assert_eq!(src.layout.size, dst.layout.size);
18081808

‎compiler/rustc_codegen_ssa/src/mir/place.rs

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ use rustc_middle::mir;
99
use rustc_middle::mir::tcx::PlaceTy;
1010
use rustc_middle::ty::layout::{HasTyCtxt, LayoutOf, TyAndLayout};
1111
use rustc_middle::ty::{self, Ty};
12-
use rustc_target::abi::{Abi, Align, FieldsShape, Int, TagEncoding};
12+
use rustc_target::abi::{Abi, Align, FieldsShape, Int, Pointer, TagEncoding};
1313
use rustc_target::abi::{VariantIdx, Variants};
1414

1515
#[derive(Copy, Clone, Debug)]
@@ -209,6 +209,7 @@ impl<'a, 'tcx, V: CodegenObject> PlaceRef<'tcx, V> {
209209
bx: &mut Bx,
210210
cast_to: Ty<'tcx>,
211211
) -> V {
212+
let dl = &bx.tcx().data_layout;
212213
let cast_to_layout = bx.cx().layout_of(cast_to);
213214
let cast_to_size = cast_to_layout.layout.size();
214215
let cast_to = bx.cx().immediate_backend_type(cast_to_layout);
@@ -250,12 +251,14 @@ impl<'a, 'tcx, V: CodegenObject> PlaceRef<'tcx, V> {
250251
TagEncoding::Niche { untagged_variant, ref niche_variants, niche_start } => {
251252
// Cast to an integer so we don't have to treat a pointer as a
252253
// special case.
253-
let (tag, tag_llty) = if tag_scalar.primitive().is_ptr() {
254-
let t = bx.type_isize();
255-
let tag = bx.ptrtoint(tag_imm, t);
256-
(tag, t)
257-
} else {
258-
(tag_imm, bx.cx().immediate_backend_type(tag_op.layout))
254+
let (tag, tag_llty) = match tag_scalar.primitive() {
255+
// FIXME(erikdesjardins): handle non-default addrspace ptr sizes
256+
Pointer(_) => {
257+
let t = bx.type_from_integer(dl.ptr_sized_integer());
258+
let tag = bx.ptrtoint(tag_imm, t);
259+
(tag, t)
260+
}
261+
_ => (tag_imm, bx.cx().immediate_backend_type(tag_op.layout)),
259262
};
260263

261264
let tag_size = tag_scalar.size(bx.cx());

‎compiler/rustc_const_eval/src/interpret/operand.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -319,7 +319,7 @@ impl<'mir, 'tcx: 'mir, M: Machine<'mir, 'tcx>> InterpCx<'mir, 'tcx, M> {
319319
assert_eq!(size, mplace.layout.size, "abi::Scalar size does not match layout size");
320320
let scalar = alloc.read_scalar(
321321
alloc_range(Size::ZERO, size),
322-
/*read_provenance*/ s.is_ptr(),
322+
/*read_provenance*/ matches!(s, abi::Pointer(_)),
323323
)?;
324324
Some(ImmTy { imm: scalar.into(), layout: mplace.layout })
325325
}
@@ -335,11 +335,11 @@ impl<'mir, 'tcx: 'mir, M: Machine<'mir, 'tcx>> InterpCx<'mir, 'tcx, M> {
335335
assert!(b_offset.bytes() > 0); // in `operand_field` we use the offset to tell apart the fields
336336
let a_val = alloc.read_scalar(
337337
alloc_range(Size::ZERO, a_size),
338-
/*read_provenance*/ a.is_ptr(),
338+
/*read_provenance*/ matches!(a, abi::Pointer(_)),
339339
)?;
340340
let b_val = alloc.read_scalar(
341341
alloc_range(b_offset, b_size),
342-
/*read_provenance*/ b.is_ptr(),
342+
/*read_provenance*/ matches!(b, abi::Pointer(_)),
343343
)?;
344344
Some(ImmTy { imm: Immediate::ScalarPair(a_val, b_val), layout: mplace.layout })
345345
}

0 commit comments

Comments
 (0)