Skip to content

Commit addb753

Browse files
authored
Auto merge of #36117 - eddyb:llvm-hoist-meta, r=alexcrichton
llvm: backport "[SimplifyCFG] Hoisting invalidates metadata". Fixes #36023 by backporting @majnemer's LLVM patch fixing [the LLVM bug](https://llvm.org/bugs/show_bug.cgi?id=29163.) where SimplifyCFG hoisted instructions andkept their metadata (conditional `!nonnull` loads could kill a null check later if hoisted). r? @alexcrichton
2 parents 77d2cd2 + 61a639e commit addb753

File tree

3 files changed

+34
-2
lines changed

3 files changed

+34
-2
lines changed

Diff for: src/rustllvm/llvm-auto-clean-trigger

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
# If this file is modified, then llvm will be forcibly cleaned and then rebuilt.
22
# The actual contents of this file do not matter, but to trigger a change on the
33
# build bots then the contents should be changed so git updates the mtime.
4-
2016-08-17
4+
2016-08-23

Diff for: src/test/run-pass/issue-36023.rs

+32
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,32 @@
1+
// Copyright 2016 The Rust Project Developers. See the COPYRIGHT
2+
// file at the top-level directory of this distribution and at
3+
// http://rust-lang.org/COPYRIGHT.
4+
//
5+
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
6+
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
7+
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
8+
// option. This file may not be copied, modified, or distributed
9+
// except according to those terms.
10+
11+
use std::ops::Deref;
12+
13+
fn main() {
14+
if env_var("FOOBAR").as_ref().map(Deref::deref).ok() == Some("yes") {
15+
panic!()
16+
}
17+
18+
let env_home: Result<String, ()> = Ok("foo-bar-baz".to_string());
19+
let env_home = env_home.as_ref().map(Deref::deref).ok();
20+
21+
if env_home == Some("") { panic!() }
22+
}
23+
24+
#[inline(never)]
25+
fn env_var(s: &str) -> Result<String, VarError> {
26+
Err(VarError::NotPresent)
27+
}
28+
29+
pub enum VarError {
30+
NotPresent,
31+
NotUnicode(String),
32+
}

0 commit comments

Comments
 (0)