Auto merge of #26771 - bluss:str-prefix, r=Gankro

core: Use memcmp in is_prefix_of / is_suffix_of

The basic str equality in core::str calls memcmp, re-use the same
function in StrSearcher's is_prefix_of, is_suffix_of.

Author: bors

src/libcollections/str.rs

@@ -483,9 +483,7 @@ impl str {
     /// considered to be
     /// boundaries.
     ///
-    /// # Panics
-    ///
-    /// Panics if `index` is greater than `self.len()`.
+    /// Returns `false` if `index` is greater than `self.len()`.
     ///
     /// # Examples
     ///

src/libcore/str/pattern.rs

@@ -513,17 +513,16 @@ impl<'a, 'b> Pattern<'a> for &'b str {
     /// Checks whether the pattern matches at the front of the haystack
     #[inline]
     fn is_prefix_of(self, haystack: &'a str) -> bool {
-        // Use `as_bytes` so that we can slice through a character in the haystack.
-        // Since self is always valid UTF-8, this can't result in a false positive.
-        self.len() <= haystack.len() &&
-            self.as_bytes() == &haystack.as_bytes()[..self.len()]
+        haystack.is_char_boundary(self.len()) &&
+            self == &haystack[..self.len()]
     }
 
     /// Checks whether the pattern matches at the back of the haystack
     #[inline]
     fn is_suffix_of(self, haystack: &'a str) -> bool {
         self.len() <= haystack.len() &&
-            self.as_bytes() == &haystack.as_bytes()[haystack.len() - self.len()..]
+            haystack.is_char_boundary(haystack.len() - self.len()) &&
+            self == &haystack[haystack.len() - self.len()..]
     }
 }