lint: treat binders in improper_ctypes instead of ICE

This replaces the  in the improper_ctypes
lint with a proper diagnostic. Previously, using an  binder inside
an  block caused an internal compiler error.

Now the lint emits an FFI-safe diagnostic explaining that  binders
are not yet supported in FFI.

Includes a new UI test to ensure the behavior stays stable.

Author: SATVIKsynopsis

compiler/rustc_lint/src/types/improper_ctypes.rs

@@ -669,7 +669,17 @@ impl<'a, 'tcx> ImproperCTypesVisitor<'a, 'tcx> {
                 FfiSafe
             }
 
-            ty::UnsafeBinder(_) => todo!("FIXME(unsafe_binder)"),
+            ty::UnsafeBinder(binder) => {
+                let ty = binder.skip_binder(); // extract the inner type
+                let _vars = binder.bound_vars(); // get bound vars if needed
+
+                FfiUnsafe {
+                    ty,
+                    reason: "types containing `unsafe` binders are not yet fully supported in FFI"
+                        .into(),
+                    help: None,
+                }
+            }
 
             ty::Param(..)
             | ty::Alias(ty::Projection | ty::Inherent | ty::Free, ..)
@@ -1016,7 +1026,6 @@ impl<'tcx> LateLintPass<'tcx> for ImproperCTypesLint {
             | hir::ItemKind::ExternCrate(..) => {}
         }
     }
-
     fn check_field_def(&mut self, cx: &LateContext<'tcx>, field: &'tcx hir::FieldDef<'tcx>) {
         self.check_type_for_external_abi_fnptr(
             cx,

tests/ui/lint/improper-ctypes/unsafe-binder-basic.rs

@@ -0,0 +1,11 @@
+// build-fail
+#![feature(unsafe_binders)]
+//~^ WARN the feature `unsafe_binders` is incomplete
+#![deny(improper_ctypes)]
+
+extern "C" {
+    fn exit_2(x: unsafe<'a> &'a ());
+    //~^ ERROR `extern` block uses type `&()`, which is not FFI-safe
+}
+
+fn main() {}

tests/ui/lint/improper-ctypes/unsafe-binder-basic.stderr

@@ -0,0 +1,24 @@
+warning: the feature `unsafe_binders` is incomplete and may not be safe to use and/or cause compiler crashes
+  --> $DIR/unsafe-binder-basic.rs:2:12
+   |
+LL | #![feature(unsafe_binders)]
+   |            ^^^^^^^^^^^^^^
+   |
+   = note: see issue #130516 <https://github.com/rust-lang/rust/issues/130516> for more information
+   = note: `#[warn(incomplete_features)]` on by default
+
+error: `extern` block uses type `&()`, which is not FFI-safe
+  --> $DIR/unsafe-binder-basic.rs:7:18
+   |
+LL |     fn exit_2(x: unsafe<'a> &'a ());
+   |                  ^^^^^^^^^^^^^^^^^ not FFI-safe
+   |
+   = note: types containing `unsafe` binders are not yet fully supported in FFI
+note: the lint level is defined here
+  --> $DIR/unsafe-binder-basic.rs:4:9
+   |
+LL | #![deny(improper_ctypes)]
+   |         ^^^^^^^^^^^^^^^
+
+error: aborting due to 1 previous error; 1 warning emitted
+