-
Notifications
You must be signed in to change notification settings - Fork 12.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Rollup merge of #132183 - GuillaumeGomez:code-in-docblock, r=notriddle
Fix code HTML items making big blocks if too long Encountered this bug randomly where `code` item in docblocks would look like this: ![Screenshot from 2024-10-26 15-44-46](https://github.com/user-attachments/assets/a9c1df9d-5007-49eb-a7dd-a2c381b2511e) With this fix it looks like this: ![image](https://github.com/user-attachments/assets/ea918595-5434-4781-b68c-6abd38689365) r? ``@notriddle``
- Loading branch information
Showing
3 changed files
with
20 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,15 @@ | ||
// If we have a long `<code>`, we need to ensure that it'll be fully displayed on mobile, meaning | ||
// that it'll be on two lines. | ||
|
||
emulate: "iPhone 8" // it has the following size: (375, 667) | ||
go-to: "file://" + |DOC_PATH| + "/test_docs/long_code_block/index.html" | ||
// We now check that the block is on two lines: | ||
show-text: true // We need to enable text draw to be able to have the "real" size | ||
|
||
// We now check that the block is on two lines: | ||
// Little explanations for this test: if the text wasn't displayed on two lines, it would take | ||
// around 20px (which is the font size). | ||
assert-property: (".docblock p > code", {"offsetHeight": "44"}) | ||
// around 24px (which is the font size). | ||
assert-size: (".docblock p > code", {"height": 48}) | ||
|
||
// Same check, but where the long code block is also a link | ||
go-to: "file://" + |DOC_PATH| + "/test_docs/long_code_block_link/index.html" | ||
assert-property: (".docblock p > a > code", {"offsetHeight": "44"}) | ||
assert-size: (".docblock p > a > code", {"height": 48}) |