Skip to content

Commit bc68de9

Browse files
committed
remove pointless FIXME in bootstrap::download
The suggestion given by `FIXME` to use `CompilerMetadata` for `download_toolchain` in `bootstrap::download` can result in more confusion. This is because `stamp_key` is not always a date; it can also be a commit hash. Additionally, unlike in `download_beta_toolchain`, in the `download_ci_rustc` function, `version` and `commit` values are calculated separately. Signed-off-by: ozkanonur <work@onurozkan.dev>
1 parent b7d8c88 commit bc68de9

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

src/bootstrap/download.rs

-1
Original file line numberDiff line numberDiff line change
@@ -427,7 +427,6 @@ impl Config {
427427

428428
fn download_toolchain(
429429
&self,
430-
// FIXME(ozkanonur) use CompilerMetadata instead of `version: &str`
431430
version: &str,
432431
sysroot: &str,
433432
stamp_key: &str,

0 commit comments

Comments
 (0)