Skip to content

Commit

Permalink
coverage: Add UI tests for values accepted by -Cinstrument-coverage
Browse files Browse the repository at this point in the history
  • Loading branch information
Zalathar committed Oct 22, 2023
1 parent cc3dce5 commit c06b444
Show file tree
Hide file tree
Showing 11 changed files with 66 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/tools/tidy/src/ui_tests.rs
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ use std::path::{Path, PathBuf};
const ENTRY_LIMIT: usize = 900;
// FIXME: The following limits should be reduced eventually.
const ISSUES_ENTRY_LIMIT: usize = 1854;
const ROOT_ENTRY_LIMIT: usize = 865;
const ROOT_ENTRY_LIMIT: usize = 866;

const EXPECTED_TEST_FILE_EXTENSIONS: &[&str] = &[
"rs", // test source files
Expand Down
23 changes: 23 additions & 0 deletions tests/codegen/instrument-coverage-off.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
// Test that `-Cinstrument-coverage=off` does not add coverage instrumentation to LLVM IR.

// needs-profiler-support
// revisions: n no off false zero
// [n] compile-flags: -Cinstrument-coverage=n
// [no] compile-flags: -Cinstrument-coverage=no
// [off] compile-flags: -Cinstrument-coverage=off
// [false] compile-flags: -Cinstrument-coverage=false
// [zero] compile-flags: -Cinstrument-coverage=0

// CHECK-NOT: __llvm_profile_filename
// CHECK-NOT: __llvm_coverage_mapping

#![crate_type="lib"]

#[inline(never)]
fn some_function() {

}

pub fn some_other_function() {
some_function();
}
9 changes: 8 additions & 1 deletion tests/codegen/instrument-coverage.rs
Original file line number Diff line number Diff line change
@@ -1,9 +1,16 @@
// Test that `-Cinstrument-coverage` creates expected __llvm_profile_filename symbol in LLVM IR.

// needs-profiler-support
// compile-flags: -Cinstrument-coverage
// revisions: y yes on true blank all
// [y] compile-flags: -Cinstrument-coverage=y
// [yes] compile-flags: -Cinstrument-coverage=yes
// [on] compile-flags: -Cinstrument-coverage=on
// [true] compile-flags: -Cinstrument-coverage=true
// [blank] compile-flags: -Cinstrument-coverage
// [all] compile-flags: -Cinstrument-coverage=all

// CHECK: @__llvm_profile_filename = {{.*}}"default_%m_%p.profraw\00"{{.*}}
// CHECK: @__llvm_coverage_mapping

#![crate_type="lib"]

Expand Down
3 changes: 3 additions & 0 deletions tests/ui/instrument-coverage/bad-value.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
// compile-flags: -Cinstrument-coverage=bad-value

fn main() {}
2 changes: 2 additions & 0 deletions tests/ui/instrument-coverage/bad-value.stderr
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
error: incorrect value `bad-value` for codegen option `instrument-coverage` - `all` (default), `except-unused-generics`, `except-unused-functions`, or `off` was expected

3 changes: 3 additions & 0 deletions tests/ui/instrument-coverage/except-unused-functions.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
// compile-flags: -Cinstrument-coverage=except-unused-functions

fn main() {}
2 changes: 2 additions & 0 deletions tests/ui/instrument-coverage/except-unused-functions.stderr
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
error: `-C instrument-coverage=except-*` requires `-Z unstable-options`

3 changes: 3 additions & 0 deletions tests/ui/instrument-coverage/except-unused-generics.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
// compile-flags: -Cinstrument-coverage=except-unused-generics

fn main() {}
2 changes: 2 additions & 0 deletions tests/ui/instrument-coverage/except-unused-generics.stderr
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
error: `-C instrument-coverage=except-*` requires `-Z unstable-options`

9 changes: 9 additions & 0 deletions tests/ui/instrument-coverage/off-values.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
// check-pass
// revisions: n no off false zero
// [n] compile-flags: -Cinstrument-coverage=n
// [no] compile-flags: -Cinstrument-coverage=no
// [off] compile-flags: -Cinstrument-coverage=off
// [false] compile-flags: -Cinstrument-coverage=false
// [zero] compile-flags: -Cinstrument-coverage=0

fn main() {}
10 changes: 10 additions & 0 deletions tests/ui/instrument-coverage/on-values.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
// check-pass
// revisions: y yes on true blank all
// [y] compile-flags: -Cinstrument-coverage=y
// [yes] compile-flags: -Cinstrument-coverage=yes
// [on] compile-flags: -Cinstrument-coverage=on
// [true] compile-flags: -Cinstrument-coverage=true
// [blank] compile-flags: -Cinstrument-coverage
// [all] compile-flags: -Cinstrument-coverage=all

fn main() {}

0 comments on commit c06b444

Please sign in to comment.