Skip to content

Commit c329a1f

Browse files
committed
auto merge of #14313 : kballard/rust/tuple_dotdot_match_ice, r=cmr
Fixes #14308.
2 parents ad775be + 0718259 commit c329a1f

File tree

2 files changed

+36
-1
lines changed

2 files changed

+36
-1
lines changed

src/librustc/middle/trans/_match.rs

+4-1
Original file line numberDiff line numberDiff line change
@@ -810,6 +810,9 @@ fn enter_tuple_struct<'a, 'b>(
810810
ast::PatEnum(_, Some(ref elts)) => {
811811
Some(elts.iter().map(|x| (*x)).collect())
812812
}
813+
ast::PatEnum(_, None) => {
814+
Some(Vec::from_elem(n_elts, dummy))
815+
}
813816
_ => {
814817
assert_is_binding_or_wild(bcx, p);
815818
Some(Vec::from_elem(n_elts, dummy))
@@ -1117,7 +1120,7 @@ fn any_tuple_struct_pat(bcx: &Block, m: &[Match], col: uint) -> bool {
11171120
m.iter().any(|br| {
11181121
let pat = *br.pats.get(col);
11191122
match pat.node {
1120-
ast::PatEnum(_, Some(_)) => {
1123+
ast::PatEnum(_, _) => {
11211124
match bcx.tcx().def_map.borrow().find(&pat.id) {
11221125
Some(&ast::DefFn(..)) |
11231126
Some(&ast::DefStruct(..)) => true,

src/test/run-pass/issue-14308.rs

+32
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,32 @@
1+
// Copyright 2014 The Rust Project Developers. See the COPYRIGHT
2+
// file at the top-level directory of this distribution and at
3+
// http://rust-lang.org/COPYRIGHT.
4+
//
5+
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
6+
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
7+
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
8+
// option. This file may not be copied, modified, or distributed
9+
// except according to those terms.
10+
11+
struct A(int);
12+
struct B;
13+
14+
fn main() {
15+
let x = match A(3) {
16+
A(..) => 1
17+
};
18+
assert_eq!(x, 1);
19+
let x = match A(4) {
20+
A(1) => 1,
21+
A(..) => 2
22+
};
23+
assert_eq!(x, 2);
24+
25+
// This next test uses a (..) wildcard match on a nullary struct.
26+
// There's no particularly good reason to support this, but it's currently allowed,
27+
// and this makes sure it doesn't ICE or break LLVM.
28+
let x = match B {
29+
B(..) => 3
30+
};
31+
assert_eq!(x, 3);
32+
}

0 commit comments

Comments
 (0)