rustc_span: note the perf loss seen from IndexSet in symbol::Interner

rust-lang · Aug 9, 2020 · ca0b89a · ca0b89a
1 parent 1d03ffe
commit ca0b89a
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/src/librustc_span/symbol.rs b/src/librustc_span/symbol.rs
@@ -1481,6 +1481,10 @@ impl<CTX> ToStableHashKey<CTX> for Symbol {
 }
 
 // The `&'static str`s in this type actually point into the arena.
+//
+// The `FxHashMap`+`Vec` pair could be replaced by `FxIndexSet`, but #75278
+// found that to regress performance up to 2% in some cases. This might be
+// revisited after further improvements to `indexmap`.
 #[derive(Default)]
 pub struct Interner {
     arena: DroplessArena,