Warn on unused_attributes in tests

JonathanBrouwer · JonathanBrouwer · commit d92a1d49d98b · 2025-10-18T12:58:47.000+02:00
Signed-off-by: Jonathan Brouwer &lt;jonathantbrouwer@gmail.com&gt;
diff --git a/src/tools/compiletest/src/runtest.rs b/src/tools/compiletest/src/runtest.rs
@@ -1838,8 +1838,9 @@ impl<'test> TestCx<'test> {
 
         // Add `-A unused` before `config` flags and in-test (`props`) flags, so that they can
         // overwrite this.
+        // Don't allow `unused_attributes` since these are usually actual mistakes, rather than just unused code.
         if let AllowUnused::Yes = allow_unused {
-            rustc.args(&["-A", "unused"]);
+            rustc.args(&["-A", "unused", "-W", "unused_attributes"]);
         }
 
         // Allow tests to use internal features.

Original file line number	Diff line number	Diff line change
`@@ -1838,8 +1838,9 @@ impl<'test> TestCx<'test> {`
`1838`	`1838`
`1839`	`1839`	// Add `-A unused` before `config` flags and in-test (`props`) flags, so that they can
`1840`	`1840`	`// overwrite this.`
	`1841`	+ // Don't allow `unused_attributes` since these are usually actual mistakes, rather than just unused code.
`1841`	`1842`	`if let AllowUnused::Yes = allow_unused {`
`1842`		`- rustc.args(&["-A", "unused"]);`
	`1843`	`+ rustc.args(&["-A", "unused", "-W", "unused_attributes"]);`
`1843`	`1844`	`}`
`1844`	`1845`
`1845`	`1846`	`// Allow tests to use internal features.`