Skip to content

Commit dbf6ac3

Browse files
Fail toolstate like before on the PR builder
The previous commit changed toolstate to never fail the build (excluding beta week and beta/stable branches). This amends that logic to also fail the PR builder "as if" we were on beta, since a PR author changing a submodule likely does want some indication of failure rather than silent acceptance. Ideally, there'd be some way to provide a "warning" but I don't believe that's possible with current set of checks.
1 parent 6096f82 commit dbf6ac3

File tree

2 files changed

+6
-0
lines changed

2 files changed

+6
-0
lines changed

src/ci/azure-pipelines/pr.yml

+1
Original file line numberDiff line numberDiff line change
@@ -32,4 +32,5 @@ jobs:
3232
parameters:
3333
only_on_updated_submodules: 'yes'
3434
variables:
35+
FORCE_FAIL_TOOLSTATE: true
3536
IMAGE: x86_64-gnu-tools

src/ci/docker/x86_64-gnu-tools/checktools.sh

+5
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,11 @@ verify_submodule_changed() {
6161
if [ $SIX_WEEK_CYCLE -ge 35 ]; then
6262
exit 3
6363
fi
64+
# we want the PR builder to error out even though the auto branch
65+
# builder will not
66+
if [ -n "$FORCE_FAIL_TOOLSTATE" ]; then
67+
exit 3
68+
fi
6469
fi
6570
fi
6671
}

0 commit comments

Comments
 (0)