auto merge of #11091 : brson/rust/cratelinkattr, r=brson

This is set to *forbid* and prints a note explaining how to fix the problem.

Author: bors

src/etc/combine-tests.py

@@ -46,7 +46,6 @@ def scrub(b):
 // AUTO-GENERATED FILE: DO NOT EDIT
 #[crate_id=\"run_pass_stage2#0.1\"];
 #[pkgid=\"run_pass_stage2#0.1\"];
-#[link(name=\"run_pass_stage2\", vers=\"0.1\")];
 #[feature(globs, macro_rules, struct_variant, managed_boxes)];
 #[allow(warnings)];
 """

src/librustc/middle/lint.rs

@@ -872,6 +872,12 @@ fn check_crate_attrs_usage(cx: &Context, attrs: &[ast::Attribute]) {
         if !iter.any(|other_attr| { name.equiv(other_attr) }) {
             cx.span_lint(attribute_usage, attr.span, "unknown crate attribute");
         }
+        if name.equiv(& &"link") {
+            cx.tcx.sess.span_err(attr.span,
+                                 "obsolete crate `link` attribute");
+            cx.tcx.sess.note("the link attribute has been superceded by the crate_id \
+                             attribute, which has the format `#[crate_id = \"name#version\"]`");
+        }
     }
 }
 

src/test/auxiliary/cci_impl_lib.rs

@@ -9,8 +9,6 @@
 // except according to those terms.
 
 #[crate_id="cci_impl_lib"];
-// NOTE: remove after the next snapshot
-#[link(name="cci_impl_lib", vers="0.0")];
 
 trait uint_helpers {
     fn to(&self, v: uint, f: |uint|);

src/test/auxiliary/cci_iter_lib.rs

@@ -9,8 +9,6 @@
 // except according to those terms.
 
 #[crate_id="cci_iter_lib"];
-// NOTE: remove after the next snapshot
-#[link(name="cci_iter_lib", vers="0.0")];
 
 #[inline]
 pub fn iter<T>(v: &[T], f: |&T|) {

src/test/auxiliary/cci_no_inline_lib.rs

@@ -9,8 +9,6 @@
 // except according to those terms.
 
 #[crate_id="cci_no_inline_lib"];
-// NOTE: remove after the next snapshot
-#[link(name="cci_no_inline_lib", vers="0.0")];
 
 // same as cci_iter_lib, more-or-less, but not marked inline
 pub fn iter(v: ~[uint], f: |uint|) {

src/test/auxiliary/crate-method-reexport-grrrrrrr2.rs

@@ -10,8 +10,6 @@
 
 #[feature(managed_boxes)];
 #[crate_id="crate_method_reexport_grrrrrrr2"];
-// NOTE: remove after the next snapshot
-#[link(name = "crate_method_reexport_grrrrrrr2")];
 
 pub use name_pool::add;
 

src/test/auxiliary/crateresolve1-1.rs

@@ -9,9 +9,6 @@
 // except according to those terms.
 
 #[crate_id="crateresolve1#0.1"];
-// NOTE: remove after the next snapshot
-#[link(name = "crateresolve1",
-       vers = "0.1")];
 
 #[crate_type = "lib"];
 

src/test/auxiliary/crateresolve1-2.rs

@@ -9,9 +9,6 @@
 // except according to those terms.
 
 #[crate_id="crateresolve1#0.2"];
-// NOTE: remove after the next snapshot
-#[link(name = "crateresolve1",
-       vers = "0.2")];
 
 #[crate_type = "lib"];
 

src/test/auxiliary/crateresolve1-3.rs

@@ -9,9 +9,6 @@
 // except according to those terms.
 
 #[crate_id="crateresolve1#0.3"];
-// NOTE: remove after the next snapshot
-#[link(name = "crateresolve1",
-       vers = "0.3")];
 
 #[crate_type = "lib"];
 

src/test/auxiliary/crateresolve2-1.rs

@@ -9,9 +9,6 @@
 // except according to those terms.
 
 #[crate_id="crateresolve2#0.1"];
-// NOTE: remove after the next snapshot
-#[link(name = "crateresolve2",
-       vers = "0.1")];
 
 #[crate_type = "lib"];