Skip to content

Commit e2349ea

Browse files
committed
A trait's local impls are trivially coherent if there are no impls.
This avoids creating a dependency edge on the hir or the specialization graph
1 parent 98aa362 commit e2349ea

File tree

1 file changed

+3
-1
lines changed
  • compiler/rustc_hir_analysis/src/coherence

1 file changed

+3
-1
lines changed

compiler/rustc_hir_analysis/src/coherence/mod.rs

+3-1
Original file line numberDiff line numberDiff line change
@@ -120,11 +120,13 @@ pub fn provide(providers: &mut Providers) {
120120
}
121121

122122
fn coherent_trait(tcx: TyCtxt<'_>, def_id: DefId) -> Result<(), ErrorGuaranteed> {
123+
// If there are no impls for the trait, then "all impls" are trivially coherent and we won't check anything
124+
// anyway. Thus we bail out even before the specialization graph, avoiding the dep_graph edge.
125+
let Some(impls) = tcx.all_local_trait_impls(()).get(&def_id) else { return Ok(()) };
123126
// Trigger building the specialization graph for the trait. This will detect and report any
124127
// overlap errors.
125128
let mut res = tcx.ensure().specialization_graph_of(def_id);
126129

127-
let impls = tcx.hir().trait_impls(def_id);
128130
for &impl_def_id in impls {
129131
let trait_ref = tcx.impl_trait_ref(impl_def_id).unwrap().instantiate_identity();
130132

0 commit comments

Comments
 (0)