Skip to content

Commit

Permalink
Remove broken clap versions from cargotest
Browse files Browse the repository at this point in the history
treeify depends on an outdated version of clap, which will fail to compile
when we promote missing_fragment_specifier future compat lint to
error (ie, old clap contains code that shouldn't have compiled in the
first place).

Additionally, this crate seem tiny relative to other crates we are
testing here, so it seems like it doesn't provide that much additional
confidence.

The same happens with tokei project, but it is an actively maintained
one, so we can just upgrade it to a version from 2018, where clap was
upgraded.
  • Loading branch information
matklad committed Aug 18, 2020
1 parent 5ba9610 commit eb4d6b5
Showing 1 changed file with 1 addition and 8 deletions.
9 changes: 1 addition & 8 deletions src/tools/cargotest/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -29,14 +29,7 @@ const TEST_REPOS: &'static [Test] = &[
Test {
name: "tokei",
repo: "https://github.com/XAMPPRocky/tokei",
sha: "5e11c4852fe4aa086b0e4fe5885822fbe57ba928",
lock: None,
packages: &[],
},
Test {
name: "treeify",
repo: "https://github.com/dzamlo/treeify",
sha: "999001b223152441198f117a68fb81f57bc086dd",
sha: "a950ff128d5a435a8083b1c7577c0431f98360ca",
lock: None,
packages: &[],
},
Expand Down

0 comments on commit eb4d6b5

Please sign in to comment.