Skip to content

Commit eee85d7

Browse files
tesujinikic
andauthored
Apply suggestions from code review
Co-authored-by: Nikita Popov <github@npopov.com>
1 parent f711bee commit eee85d7

4 files changed

+6
-6
lines changed

tests/assembly/issue-83585-small-pod-struct-equality.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ type T2 = [T; 8];
1212
#[no_mangle]
1313
// CHECK-LABEL: foo1a
1414
// CHECK: cmp
15-
// CHECK-NEXT: set
15+
// CHECK-NEXT: sete
1616
// CHECK-NEXT: ret
1717
pub fn foo1a(a: T1, b: T1) -> bool {
1818
a == b
@@ -22,7 +22,7 @@ pub fn foo1a(a: T1, b: T1) -> bool {
2222
// CHECK-LABEL: foo1b
2323
// CHECK: mov
2424
// CHECK-NEXT: cmp
25-
// CHECK-NEXT: set
25+
// CHECK-NEXT: sete
2626
// CHECK-NEXT: ret
2727
pub fn foo1b(a: &T1, b: &T1) -> bool {
2828
a == b

tests/codegen/issues/issue-36010-some-box-is_some.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -13,15 +13,15 @@ fn foo<T>(a: &mut T, b: T) -> bool {
1313

1414
// CHECK-LABEL: @foo_u32
1515
// CHECK: store i32
16-
// CHECK-NEXT: ret i1
16+
// CHECK-NEXT: ret i1 true
1717
#[no_mangle]
1818
pub fn foo_u32(a: &mut u32, b: u32) -> bool {
1919
foo(a, b)
2020
}
2121

2222
// CHECK-LABEL: @foo_box
2323
// CHECK: store ptr
24-
// CHECK-NEXT: ret i1
24+
// CHECK-NEXT: ret i1 true
2525
#[no_mangle]
2626
pub fn foo_box(a: &mut Box<u32>, b: Box<u32>) -> bool {
2727
foo(a, b)

tests/codegen/issues/issue-74938-array-split-at.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ pub type T = u8;
88
#[no_mangle]
99
// CHECK-LABEL: @split_mutiple
1010
// CHECK-NOT: unreachable
11-
pub fn split_mutiple(slice: &[T]) -> (&[T], &[T]) {
11+
pub fn split_multiple(slice: &[T]) -> (&[T], &[T]) {
1212
let len = slice.len() / N;
1313
slice.split_at(len * N)
1414
}

tests/codegen/slice-pointer-nonnull-unwrap.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
use std::ptr::NonNull;
66

77
// CHECK-LABEL: @slice_ptr_len_1
8-
// CHECK: {{.*}}:
8+
// CHECK-NEXT: {{.*}}:
99
// CHECK-NEXT: ret i64 %ptr.1
1010
#[no_mangle]
1111
pub fn slice_ptr_len_1(ptr: *const [u8]) -> usize {

0 commit comments

Comments
 (0)