Skip to content

Commit

Permalink
Update reason why fmt-write-bloat ignores windows
Browse files Browse the repository at this point in the history
  • Loading branch information
ChrisDenton committed Aug 9, 2024
1 parent 2cc029e commit ef90df6
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions tests/run-make/fmt-write-bloat/rmake.rs
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,12 @@
//! `NO_DEBUG_ASSERTIONS=1`). If debug assertions are disabled, then we can check for the absence of
//! additional `usize` formatting and padding related symbols.

// Reason: This test is `ignore-windows` because the `no_std` test (using `#[link(name = "c")])`
// doesn't link on windows.
//@ ignore-windows
// Reason:
// - MSVC targets really need to parse the .pdb file (aka the debug information).
// On Windows there's an API for that (dbghelp) which maybe we can use
// - MinGW targets have a lot of symbols included in their runtime which we can't avoid.
// We would need to make the symbols we're looking for more specific for this test to work.
//@ ignore-cross-compile

use run_make_support::env::no_debug_assertions;
Expand Down

0 comments on commit ef90df6

Please sign in to comment.