-
Notifications
You must be signed in to change notification settings - Fork 12.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Rollup merge of #84221 - ABouttefeux:generic-arg-elision, r=estebank
E0599 suggestions and elision of generic argument if no canditate is found fixes #81576 changes: In error E0599 (method not found) generic argument are eluded if the method was not found anywhere. If the method was found in another inherent implementation suggest that it was found elsewhere. Example ```rust struct Wrapper<T>(T); struct Wrapper2<T> { x: T, } impl Wrapper2<i8> { fn method(&self) {} } fn main() { let wrapper = Wrapper(i32); wrapper.method(); let wrapper2 = Wrapper2{x: i32}; wrapper2.method(); } ``` ``` Error[E0599]: no method named `method` found for struct `Wrapper<_>` in the current scope .... error[E0599]: no method named `method` found for struct `Wrapper2<i32>` in the current scope ... = note: The method was found for Wrapper2<i8>. ``` I am not very happy with the ```no method named `test` found for struct `Vec<_, _>` in the current scope```. I think it might be better to show only one generic argument `Vec<_>` if there is a default one. But I haven't yet found a way to do that,
- Loading branch information
Showing
7 changed files
with
308 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
106 changes: 106 additions & 0 deletions
106
src/test/ui/methods/method-not-found-generic-arg-elision.rs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,106 @@ | ||
| // Test for issue 81576 | ||
| // Remove generic arguments if no method is found for all possible generic argument | ||
|
|
||
| use std::marker::PhantomData; | ||
|
|
||
| struct Wrapper2<'a, T, const C: usize> { | ||
| x: &'a T, | ||
| } | ||
|
|
||
| impl<'a, const C: usize> Wrapper2<'a, i8, C> { | ||
| fn method(&self) {} | ||
| } | ||
|
|
||
| impl<'a, const C: usize> Wrapper2<'a, i16, C> { | ||
| fn method(&self) {} | ||
| } | ||
|
|
||
| impl<'a, const C: usize> Wrapper2<'a, i32, C> { | ||
| fn method(&self) {} | ||
| } | ||
| struct Wrapper<T>(T); | ||
|
|
||
| impl Wrapper<i8> { | ||
| fn method(&self) {} | ||
| } | ||
|
|
||
| impl Wrapper<i16> { | ||
| fn method(&self) {} | ||
| } | ||
|
|
||
| impl Wrapper<i32> { | ||
| fn method(&self) {} | ||
| } | ||
|
|
||
| impl Wrapper<i64> { | ||
| fn method(&self) {} | ||
| } | ||
|
|
||
| impl Wrapper<u8> { | ||
| fn method(&self) {} | ||
| } | ||
|
|
||
| impl Wrapper<u16> { | ||
| fn method(&self) {} | ||
| } | ||
|
|
||
| struct Point<T> { | ||
| x: T, | ||
| y: T, | ||
| } | ||
|
|
||
| impl Point<f64> { | ||
| fn distance(&self) -> f64 { | ||
| self.x.hypot(self.y) | ||
| } | ||
| } | ||
|
|
||
| struct Other; | ||
|
|
||
| impl Other { | ||
| fn other(&self) {} | ||
| } | ||
|
|
||
| struct Struct<T>{ | ||
| _phatom: PhantomData<T> | ||
| } | ||
|
|
||
| impl<T> Default for Struct<T> { | ||
| fn default() -> Self { | ||
| Self{ _phatom: PhantomData } | ||
| } | ||
| } | ||
|
|
||
| impl<T: Clone + Copy + PartialEq + Eq + PartialOrd + Ord> Struct<T> { | ||
| fn method(&self) {} | ||
| } | ||
|
|
||
| fn main() { | ||
| let point_f64 = Point{ x: 1_f64, y: 1_f64}; | ||
| let d = point_f64.distance(); | ||
| let point_i32 = Point{ x: 1_i32, y: 1_i32}; | ||
| let d = point_i32.distance(); | ||
| //~^ ERROR no method named `distance` found for struct `Point<i32> | ||
| let d = point_i32.other(); | ||
| //~^ ERROR no method named `other` found for struct `Point | ||
| let v = vec![1_i32, 2, 3]; | ||
| v.iter().map(|x| x * x).extend(std::iter::once(100)); | ||
| //~^ ERROR no method named `extend` found for struct `Map | ||
| let wrapper = Wrapper(true); | ||
| wrapper.method(); | ||
| //~^ ERROR no method named `method` found for struct `Wrapper<bool> | ||
| wrapper.other(); | ||
| //~^ ERROR no method named `other` found for struct `Wrapper | ||
| let boolean = true; | ||
| let wrapper = Wrapper2::<'_, _, 3> {x: &boolean}; | ||
| wrapper.method(); | ||
| //~^ ERROR no method named `method` found for struct `Wrapper2<'_, bool, 3_usize> | ||
| wrapper.other(); | ||
| //~^ ERROR no method named `other` found for struct `Wrapper2 | ||
| let a = vec![1, 2, 3]; | ||
| a.not_found(); | ||
| //~^ ERROR no method named `not_found` found for struct `Vec | ||
| let s = Struct::<f64>::default(); | ||
| s.method(); | ||
| //~^ ERROR the method `method` exists for struct `Struct<f64>`, but its trait bounds were not satisfied | ||
| } |
97 changes: 97 additions & 0 deletions
97
src/test/ui/methods/method-not-found-generic-arg-elision.stderr
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,97 @@ | ||
| error[E0599]: no method named `distance` found for struct `Point<i32>` in the current scope | ||
| --> $DIR/method-not-found-generic-arg-elision.rs:82:23 | ||
| | | ||
| LL | struct Point<T> { | ||
| | --------------- method `distance` not found for this | ||
| ... | ||
| LL | let d = point_i32.distance(); | ||
| | ^^^^^^^^ method not found in `Point<i32>` | ||
| | | ||
| = note: the method was found for | ||
| - `Point<f64>` | ||
|
|
||
| error[E0599]: no method named `other` found for struct `Point` in the current scope | ||
| --> $DIR/method-not-found-generic-arg-elision.rs:84:23 | ||
| | | ||
| LL | struct Point<T> { | ||
| | --------------- method `other` not found for this | ||
| ... | ||
| LL | let d = point_i32.other(); | ||
| | ^^^^^ method not found in `Point<i32>` | ||
|
|
||
| error[E0599]: no method named `extend` found for struct `Map` in the current scope | ||
| --> $DIR/method-not-found-generic-arg-elision.rs:87:29 | ||
| | | ||
| LL | v.iter().map(|x| x * x).extend(std::iter::once(100)); | ||
| | ^^^^^^ method not found in `Map<std::slice::Iter<'_, i32>, [closure@$DIR/method-not-found-generic-arg-elision.rs:87:18: 87:27]>` | ||
|
|
||
| error[E0599]: no method named `method` found for struct `Wrapper<bool>` in the current scope | ||
| --> $DIR/method-not-found-generic-arg-elision.rs:90:13 | ||
| | | ||
| LL | struct Wrapper<T>(T); | ||
| | --------------------- method `method` not found for this | ||
| ... | ||
| LL | wrapper.method(); | ||
| | ^^^^^^ method not found in `Wrapper<bool>` | ||
| | | ||
| = note: the method was found for | ||
| - `Wrapper<i8>` | ||
| - `Wrapper<i16>` | ||
| - `Wrapper<i32>` | ||
| - `Wrapper<i64>` | ||
| and 2 more types | ||
|
|
||
| error[E0599]: no method named `other` found for struct `Wrapper` in the current scope | ||
| --> $DIR/method-not-found-generic-arg-elision.rs:92:13 | ||
| | | ||
| LL | struct Wrapper<T>(T); | ||
| | --------------------- method `other` not found for this | ||
| ... | ||
| LL | wrapper.other(); | ||
| | ^^^^^ method not found in `Wrapper<bool>` | ||
|
|
||
| error[E0599]: no method named `method` found for struct `Wrapper2<'_, bool, 3_usize>` in the current scope | ||
| --> $DIR/method-not-found-generic-arg-elision.rs:96:13 | ||
| | | ||
| LL | struct Wrapper2<'a, T, const C: usize> { | ||
| | -------------------------------------- method `method` not found for this | ||
| ... | ||
| LL | wrapper.method(); | ||
| | ^^^^^^ method not found in `Wrapper2<'_, bool, 3_usize>` | ||
| | | ||
| = note: the method was found for | ||
| - `Wrapper2<'a, i8, C>` | ||
| - `Wrapper2<'a, i16, C>` | ||
| - `Wrapper2<'a, i32, C>` | ||
|
|
||
| error[E0599]: no method named `other` found for struct `Wrapper2` in the current scope | ||
| --> $DIR/method-not-found-generic-arg-elision.rs:98:13 | ||
| | | ||
| LL | struct Wrapper2<'a, T, const C: usize> { | ||
| | -------------------------------------- method `other` not found for this | ||
| ... | ||
| LL | wrapper.other(); | ||
| | ^^^^^ method not found in `Wrapper2<'_, bool, 3_usize>` | ||
|
|
||
| error[E0599]: no method named `not_found` found for struct `Vec<{integer}>` in the current scope | ||
| --> $DIR/method-not-found-generic-arg-elision.rs:101:7 | ||
| | | ||
| LL | a.not_found(); | ||
| | ^^^^^^^^^ method not found in `Vec<{integer}>` | ||
|
|
||
| error[E0599]: the method `method` exists for struct `Struct<f64>`, but its trait bounds were not satisfied | ||
| --> $DIR/method-not-found-generic-arg-elision.rs:104:7 | ||
| | | ||
| LL | struct Struct<T>{ | ||
| | ---------------- method `method` not found for this | ||
| ... | ||
| LL | s.method(); | ||
| | ^^^^^^ method cannot be called on `Struct<f64>` due to unsatisfied trait bounds | ||
| | | ||
| = note: the following trait bounds were not satisfied: | ||
| `f64: Eq` | ||
| `f64: Ord` | ||
|
|
||
| error: aborting due to 9 previous errors | ||
|
|
||
| For more information about this error, try `rustc --explain E0599`. |