Skip to content

Commit f607eb4

Browse files
authored
Rollup merge of #113226 - lqd:win-trys, r=Kobzol
Fix try builds on the msvc builder Try builds have been optimized to build less components, however bootstrap was still expecting them to be present on msvc. This PR (extracted from #112267) fixes that. r? `@Kobzol`
2 parents bcd804b + a158053 commit f607eb4

File tree

1 file changed

+48
-40
lines changed

1 file changed

+48
-40
lines changed

src/bootstrap/dist.rs

+48-40
Original file line numberDiff line numberDiff line change
@@ -1601,9 +1601,7 @@ impl Step for Extended {
16011601
prepare("cargo");
16021602
prepare("rust-analysis");
16031603
prepare("rust-std");
1604-
prepare("clippy");
1605-
prepare("rust-analyzer");
1606-
for tool in &["rust-docs", "rust-demangler", "miri"] {
1604+
for tool in &["clippy", "rust-analyzer", "rust-docs", "rust-demangler", "miri"] {
16071605
if built_tools.contains(tool) {
16081606
prepare(tool);
16091607
}
@@ -1689,40 +1687,44 @@ impl Step for Extended {
16891687
.arg("-out")
16901688
.arg(exe.join("StdGroup.wxs")),
16911689
);
1692-
builder.run(
1693-
Command::new(&heat)
1694-
.current_dir(&exe)
1695-
.arg("dir")
1696-
.arg("rust-analyzer")
1697-
.args(&heat_flags)
1698-
.arg("-cg")
1699-
.arg("RustAnalyzerGroup")
1700-
.arg("-dr")
1701-
.arg("RustAnalyzer")
1702-
.arg("-var")
1703-
.arg("var.RustAnalyzerDir")
1704-
.arg("-out")
1705-
.arg(exe.join("RustAnalyzerGroup.wxs"))
1706-
.arg("-t")
1707-
.arg(etc.join("msi/remove-duplicates.xsl")),
1708-
);
1709-
builder.run(
1710-
Command::new(&heat)
1711-
.current_dir(&exe)
1712-
.arg("dir")
1713-
.arg("clippy")
1714-
.args(&heat_flags)
1715-
.arg("-cg")
1716-
.arg("ClippyGroup")
1717-
.arg("-dr")
1718-
.arg("Clippy")
1719-
.arg("-var")
1720-
.arg("var.ClippyDir")
1721-
.arg("-out")
1722-
.arg(exe.join("ClippyGroup.wxs"))
1723-
.arg("-t")
1724-
.arg(etc.join("msi/remove-duplicates.xsl")),
1725-
);
1690+
if built_tools.contains("rust-analyzer") {
1691+
builder.run(
1692+
Command::new(&heat)
1693+
.current_dir(&exe)
1694+
.arg("dir")
1695+
.arg("rust-analyzer")
1696+
.args(&heat_flags)
1697+
.arg("-cg")
1698+
.arg("RustAnalyzerGroup")
1699+
.arg("-dr")
1700+
.arg("RustAnalyzer")
1701+
.arg("-var")
1702+
.arg("var.RustAnalyzerDir")
1703+
.arg("-out")
1704+
.arg(exe.join("RustAnalyzerGroup.wxs"))
1705+
.arg("-t")
1706+
.arg(etc.join("msi/remove-duplicates.xsl")),
1707+
);
1708+
}
1709+
if built_tools.contains("clippy") {
1710+
builder.run(
1711+
Command::new(&heat)
1712+
.current_dir(&exe)
1713+
.arg("dir")
1714+
.arg("clippy")
1715+
.args(&heat_flags)
1716+
.arg("-cg")
1717+
.arg("ClippyGroup")
1718+
.arg("-dr")
1719+
.arg("Clippy")
1720+
.arg("-var")
1721+
.arg("var.ClippyDir")
1722+
.arg("-out")
1723+
.arg(exe.join("ClippyGroup.wxs"))
1724+
.arg("-t")
1725+
.arg(etc.join("msi/remove-duplicates.xsl")),
1726+
);
1727+
}
17261728
if built_tools.contains("rust-demangler") {
17271729
builder.run(
17281730
Command::new(&heat)
@@ -1806,14 +1808,16 @@ impl Step for Extended {
18061808
.arg("-dCargoDir=cargo")
18071809
.arg("-dStdDir=rust-std")
18081810
.arg("-dAnalysisDir=rust-analysis")
1809-
.arg("-dClippyDir=clippy")
18101811
.arg("-arch")
18111812
.arg(&arch)
18121813
.arg("-out")
18131814
.arg(&output)
18141815
.arg(&input);
18151816
add_env(builder, &mut cmd, target);
18161817

1818+
if built_tools.contains("clippy") {
1819+
cmd.arg("-dClippyDir=clippy");
1820+
}
18171821
if built_tools.contains("rust-docs") {
18181822
cmd.arg("-dDocsDir=rust-docs");
18191823
}
@@ -1840,7 +1844,9 @@ impl Step for Extended {
18401844
}
18411845
candle("CargoGroup.wxs".as_ref());
18421846
candle("StdGroup.wxs".as_ref());
1843-
candle("ClippyGroup.wxs".as_ref());
1847+
if built_tools.contains("clippy") {
1848+
candle("ClippyGroup.wxs".as_ref());
1849+
}
18441850
if built_tools.contains("miri") {
18451851
candle("MiriGroup.wxs".as_ref());
18461852
}
@@ -1877,9 +1883,11 @@ impl Step for Extended {
18771883
.arg("CargoGroup.wixobj")
18781884
.arg("StdGroup.wixobj")
18791885
.arg("AnalysisGroup.wixobj")
1880-
.arg("ClippyGroup.wixobj")
18811886
.current_dir(&exe);
18821887

1888+
if built_tools.contains("clippy") {
1889+
cmd.arg("ClippyGroup.wixobj");
1890+
}
18831891
if built_tools.contains("miri") {
18841892
cmd.arg("MiriGroup.wixobj");
18851893
}

0 commit comments

Comments
 (0)