Skip to content

Commit f698774

Browse files
committed
Update comments.
1 parent aa1bc58 commit f698774

File tree

1 file changed

+5
-12
lines changed

1 file changed

+5
-12
lines changed

compiler/rustc_interface/src/passes.rs

+5-12
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ mod boxed_resolver {
100100
}
101101

102102
// Note: Drop order is important to prevent dangling references. Resolver must be dropped first,
103-
// then resolver_arenas and finally session.
103+
// then resolver_arenas and session.
104104
impl Drop for BoxedResolverInner {
105105
fn drop(&mut self) {
106106
self.resolver.take();
@@ -109,10 +109,10 @@ mod boxed_resolver {
109109
}
110110

111111
impl BoxedResolver {
112-
pub(super) fn new<F>(session: Lrc<Session>, make_resolver: F) -> Self
113-
where
114-
F: for<'a> FnOnce(&'a Session, &'a ResolverArenas<'a>) -> Resolver<'a>,
115-
{
112+
pub(super) fn new(
113+
session: Lrc<Session>,
114+
make_resolver: impl for<'a> FnOnce(&'a Session, &'a ResolverArenas<'a>) -> Resolver<'a>,
115+
) -> BoxedResolver {
116116
let mut boxed_resolver = Box::new(BoxedResolverInner {
117117
session,
118118
resolver_arenas: Some(Resolver::arenas()),
@@ -168,11 +168,6 @@ pub fn create_resolver(
168168
crate_name: &str,
169169
) -> BoxedResolver {
170170
tracing::trace!("create_resolver");
171-
// Currently, we ignore the name resolution data structures for the purposes of dependency
172-
// tracking. Instead we will run name resolution and include its output in the hash of each
173-
// item, much like we do for macro expansion. In other words, the hash reflects not just
174-
// its contents but the results of name resolution on those contents. Hopefully we'll push
175-
// this back at some point.
176171
BoxedResolver::new(sess, move |sess, resolver_arenas| {
177172
Resolver::new(sess, &krate, &crate_name, metadata_loader, &resolver_arenas)
178173
})
@@ -263,8 +258,6 @@ fn pre_expansion_lint(
263258
/// syntax expansion, secondary `cfg` expansion, synthesis of a test
264259
/// harness if one is to be provided, injection of a dependency on the
265260
/// standard library and prelude, and name resolution.
266-
///
267-
/// Returns [`None`] if we're aborting after handling -W help.
268261
pub fn configure_and_expand(
269262
sess: &Session,
270263
lint_store: &LintStore,

0 commit comments

Comments
 (0)