Skip to content

Commit

Permalink
Extend the comment of check_toolstate() to clarify that the tool wo…
Browse files Browse the repository at this point in the history
…n't be shipped on all targets
  • Loading branch information
hyd-dev committed Feb 6, 2021
1 parent f82315a commit f87afe5
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion src/tools/build-manifest/src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,10 @@ impl Builder {
t!(self.checksums.store_cache());
}

/// If a tool does not pass its tests, don't ship it.
/// If a tool does not pass its tests on *any* of Linux and Windows, don't ship
/// it on *all* targets, because tools like Miri can "cross-run" programs for
/// different targets, for example, run a program for `x86_64-pc-windows-msvc`
/// on `x86_64-unknown-linux-gnu`.
/// Right now, we do this only for Miri.
fn check_toolstate(&mut self) {
for file in &["toolstates-linux.json", "toolstates-windows.json"] {
Expand Down

0 comments on commit f87afe5

Please sign in to comment.