:: selective on any case with dyn (#91997)

Borgerr · Borgerr · commit f8911e3f65c6 · 2024-06-30T18:57:12.000-06:00
diff --git a/tests/ui/associated-types/associated-types-incomplete-object.stderr b/tests/ui/associated-types/associated-types-incomplete-object.stderr
@@ -25,7 +25,7 @@ LL |     type B;
    |     ------ `B` defined here
 ...
 LL |     let d = &42isize as &dyn Foo;
-   |                              ^^^ help: specify the associated types: `Foo::<A = Type, B = Type>`
+   |                              ^^^ help: specify the associated types: `Foo<A = Type, B = Type>`
 
 error: aborting due to 3 previous errors
 
diff --git a/tests/ui/associated-types/issue-22560.stderr b/tests/ui/associated-types/issue-22560.stderr
@@ -25,8 +25,8 @@ LL | type Test = dyn Add + Sub;
    |
 help: specify the associated types
    |
-LL | type Test = dyn Add::<Output = Type> + Sub::<Output = Type>;
-   |                 ~~~~~~~~~~~~~~~~~~~~   ~~~~~~~~~~~~~~~~~~~~
+LL | type Test = dyn Add<Output = Type> + Sub<Output = Type>;
+   |                 ~~~~~~~~~~~~~~~~~~   ~~~~~~~~~~~~~~~~~~
 
 error[E0393]: the type parameter `Rhs` must be explicitly specified
   --> $DIR/issue-22560.rs:9:17
diff --git a/tests/ui/associated-types/issue-23595-1.stderr b/tests/ui/associated-types/issue-23595-1.stderr
@@ -6,7 +6,7 @@ LL |     type Value;
 LL |     type ChildKey;
    |     ------------- `ChildKey` defined here
 LL |     type Children = dyn Index<Self::ChildKey, Output = dyn Hierarchy>;
-   |     ------------- `Children` defined here                  ^^^^^^^^^ help: specify the associated types: `Hierarchy::<Value = Type, ChildKey = Type, Children = Type>`
+   |     ------------- `Children` defined here                  ^^^^^^^^^ help: specify the associated types: `Hierarchy<Value = Type, ChildKey = Type, Children = Type>`
 
 error: aborting due to 1 previous error
 
diff --git a/tests/ui/error-codes/E0191.stderr b/tests/ui/error-codes/E0191.stderr
@@ -5,7 +5,7 @@ LL |     type Bar;
    |     -------- `Bar` defined here
 ...
 LL | type Foo = dyn Trait;
-   |                ^^^^^ help: specify the associated type: `Trait::<Bar = Type>`
+   |                ^^^^^ help: specify the associated type: `Trait<Bar = Type>`
 
 error: aborting due to 1 previous error
 
diff --git a/tests/ui/errors/dynless-turbofish-e0191-issue-91997.rs b/tests/ui/errors/dynless-turbofish-e0191-issue-91997.rs
@@ -0,0 +1,8 @@
+trait MyIterator : Iterator {}
+
+fn main() {
+    let _ = MyIterator::next;
+}
+//~^^ ERROR the value of the associated type `Item` in `Iterator` must be specified [E0191]
+//~| WARN trait objects without an explicit `dyn` are deprecated [bare_trait_objects]
+//~| WARN this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021!
diff --git a/tests/ui/errors/dynless-turbofish-e0191-issue-91997.stderr b/tests/ui/errors/dynless-turbofish-e0191-issue-91997.stderr
@@ -0,0 +1,23 @@
+warning: trait objects without an explicit `dyn` are deprecated
+  --> $DIR/dynless-turbofish-e0191-issue-91997.rs:4:13
+   |
+LL |     let _ = MyIterator::next;
+   |             ^^^^^^^^^^
+   |
+   = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021!
+   = note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2021/warnings-promoted-to-error.html>
+   = note: `#[warn(bare_trait_objects)]` on by default
+help: if this is an object-safe trait, use `dyn`
+   |
+LL |     let _ = <dyn MyIterator>::next;
+   |             ++++           +
+
+error[E0191]: the value of the associated type `Item` in `Iterator` must be specified
+  --> $DIR/dynless-turbofish-e0191-issue-91997.rs:4:13
+   |
+LL |     let _ = MyIterator::next;
+   |             ^^^^^^^^^^ help: specify the associated type: `MyIterator::<Item = Type>`
+
+error: aborting due to 1 previous error; 1 warning emitted
+
+For more information about this error, try `rustc --explain E0191`.
diff --git a/tests/ui/issues/issue-19482.stderr b/tests/ui/issues/issue-19482.stderr
@@ -5,7 +5,7 @@ LL |     type A;
    |     ------ `A` defined here
 ...
 LL | fn bar(x: &dyn Foo) {}
-   |                ^^^ help: specify the associated type: `Foo::<A = Type>`
+   |                ^^^ help: specify the associated type: `Foo<A = Type>`
 
 error: aborting due to 1 previous error
 
diff --git a/tests/ui/issues/issue-21950.stderr b/tests/ui/issues/issue-21950.stderr
@@ -5,7 +5,7 @@ LL |     type Output;
    |     ----------- `Output` defined here
 ...
 LL |     let x = &10 as &dyn Add;
-   |                         ^^^ help: specify the associated type: `Add::<Output = Type>`
+   |                         ^^^ help: specify the associated type: `Add<Output = Type>`
 
 error[E0393]: the type parameter `Rhs` must be explicitly specified
   --> $DIR/issue-21950.rs:10:25
diff --git a/tests/ui/issues/issue-22434.stderr b/tests/ui/issues/issue-22434.stderr
@@ -5,7 +5,7 @@ LL |     type A;
    |     ------ `A` defined here
 ...
 LL | type I<'a> = &'a (dyn Foo + 'a);
-   |                       ^^^ help: specify the associated type: `Foo::<A = Type>`
+   |                       ^^^ help: specify the associated type: `Foo<A = Type>`
 
 error: aborting due to 1 previous error
 
diff --git a/tests/ui/issues/issue-23024.stderr b/tests/ui/issues/issue-23024.stderr
@@ -23,7 +23,7 @@ error[E0191]: the value of the associated type `Output` in `FnOnce` must be spec
   --> $DIR/issue-23024.rs:8:39
    |
 LL |     println!("{:?}",(vfnfer[0] as dyn Fn)(3));
-   |                                       ^^ help: specify the associated type: `Fn::<Output = Type>`
+   |                                       ^^ help: specify the associated type: `Fn<Output = Type>`
 
 error: aborting due to 3 previous errors
 
diff --git a/tests/ui/object-safety/assoc_type_bounds_sized_others.stderr b/tests/ui/object-safety/assoc_type_bounds_sized_others.stderr
@@ -5,7 +5,7 @@ LL |     type Bop;
    |     -------- `Bop` defined here
 ...
 LL | fn foo(_: &dyn Foo) {}
-   |                ^^^ help: specify the associated type: `Foo::<Bop = Type>`
+   |                ^^^ help: specify the associated type: `Foo<Bop = Type>`
 
 error[E0191]: the value of the associated type `Bop` in `Bar` must be specified
   --> $DIR/assoc_type_bounds_sized_others.rs:22:16
@@ -14,7 +14,7 @@ LL |     type Bop;
    |     -------- `Bop` defined here
 ...
 LL | fn bar(_: &dyn Bar) {}
-   |                ^^^ help: specify the associated type: `Bar::<Bop = Type>`
+   |                ^^^ help: specify the associated type: `Bar<Bop = Type>`
 
 error: aborting due to 2 previous errors
 
diff --git a/tests/ui/suggestions/trait-hidden-method.stderr b/tests/ui/suggestions/trait-hidden-method.stderr
@@ -2,7 +2,7 @@ error[E0191]: the value of the associated type `Item` in `Iterator` must be spec
   --> $DIR/trait-hidden-method.rs:6:33
    |
 LL |     Box::new(1..=10) as Box<dyn Iterator>
-   |                                 ^^^^^^^^ help: specify the associated type: `Iterator::<Item = Type>`
+   |                                 ^^^^^^^^ help: specify the associated type: `Iterator<Item = Type>`
 
 error[E0271]: expected `Box<dyn Iterator>` to be an iterator that yields `u32`, but it yields `<dyn Iterator as Iterator>::Item`
   --> $DIR/trait-hidden-method.rs:3:32
diff --git a/tests/ui/traits/alias/object-fail.stderr b/tests/ui/traits/alias/object-fail.stderr
@@ -13,7 +13,7 @@ error[E0191]: the value of the associated type `Item` in `Iterator` must be spec
   --> $DIR/object-fail.rs:9:17
    |
 LL |     let _: &dyn IteratorAlias = &vec![123].into_iter();
-   |                 ^^^^^^^^^^^^^ help: specify the associated type: `IteratorAlias::<Item = Type>`
+   |                 ^^^^^^^^^^^^^ help: specify the associated type: `IteratorAlias<Item = Type>`
 
 error: aborting due to 2 previous errors
 

Original file line number	Diff line number	Diff line change
`@@ -25,8 +25,8 @@ LL \| type Test = dyn Add + Sub;`
`25`	`25`	`\|`
`26`	`26`	`help: specify the associated types`
`27`	`27`	`\|`
`28`		`-LL \| type Test = dyn Add::<Output = Type> + Sub::<Output = Type>;`
`29`		`- \| ~~~~~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~`
	`28`	`+LL \| type Test = dyn Add<Output = Type> + Sub<Output = Type>;`
	`29`	`+ \| ~~~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~`
`30`	`30`
`31`	`31`	error[E0393]: the type parameter `Rhs` must be explicitly specified
`32`	`32`	`--> $DIR/issue-22560.rs:9:17`
Original file line number	Diff line number	Diff line change
@@ -23,7 +23,7 @@ error[E0191]: the value of the associated type `Output` in `FnOnce` must be spec
`23`	`23`	`--> $DIR/issue-23024.rs:8:39`
`24`	`24`	`\|`
`25`	`25`	`LL \| println!("{:?}",(vfnfer[0] as dyn Fn)(3));`
`26`		- \| ^^ help: specify the associated type: `Fn::<Output = Type>`
	`26`	+ \| ^^ help: specify the associated type: `Fn<Output = Type>`
`27`	`27`
`28`	`28`	`error: aborting due to 3 previous errors`
`29`	`29`
Original file line number	Diff line number	Diff line change
@@ -2,7 +2,7 @@ error[E0191]: the value of the associated type `Item` in `Iterator` must be spec
`2`	`2`	`--> $DIR/trait-hidden-method.rs:6:33`
`3`	`3`	`\|`
`4`	`4`	`LL \| Box::new(1..=10) as Box<dyn Iterator>`
`5`		- \| ^^^^^^^^ help: specify the associated type: `Iterator::<Item = Type>`
	`5`	+ \| ^^^^^^^^ help: specify the associated type: `Iterator<Item = Type>`
`6`	`6`
`7`	`7`	error[E0271]: expected `Box<dyn Iterator>` to be an iterator that yields `u32`, but it yields `<dyn Iterator as Iterator>::Item`
`8`	`8`	`--> $DIR/trait-hidden-method.rs:3:32`
Original file line number	Diff line number	Diff line change
@@ -13,7 +13,7 @@ error[E0191]: the value of the associated type `Item` in `Iterator` must be spec
`13`	`13`	`--> $DIR/object-fail.rs:9:17`
`14`	`14`	`\|`
`15`	`15`	`LL \| let _: &dyn IteratorAlias = &vec![123].into_iter();`
`16`		- \| ^^^^^^^^^^^^^ help: specify the associated type: `IteratorAlias::<Item = Type>`
	`16`	+ \| ^^^^^^^^^^^^^ help: specify the associated type: `IteratorAlias<Item = Type>`
`17`	`17`
`18`	`18`	`error: aborting due to 2 previous errors`
`19`	`19`