Skip to content

Commit f97d915

Browse files
Use new utility functions/methods in run-make tests
1 parent d25cf6f commit f97d915

File tree

3 files changed

+6
-12
lines changed

3 files changed

+6
-12
lines changed

tests/run-make/doctests-keep-binaries/rmake.rs

+3-6
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,7 @@ fn main() {
2626
.arg("--test")
2727
.arg("--persist-doctests")
2828
.arg(out_dir)
29-
.arg("--extern")
30-
.arg(format!("t={}", extern_path.display()))
29+
.extern_("t", extern_path)
3130
.run();
3231
check_generated_binaries();
3332
});
@@ -38,8 +37,7 @@ fn main() {
3837
.arg("--test")
3938
.arg("--persist-doctests")
4039
.arg(out_dir)
41-
.arg("--extern")
42-
.arg(format!("t={}", extern_path.display()))
40+
.extern_("t", extern_path)
4341
.arg("--no-run")
4442
.run();
4543
check_generated_binaries();
@@ -59,8 +57,7 @@ fn main() {
5957
.arg("doctests")
6058
.arg("--test-run-directory")
6159
.arg(run_dir)
62-
.arg("--extern")
63-
.arg("t=libt.rlib")
60+
.extern_("t", "libt.rlib")
6461
.run();
6562

6663
remove_dir_all(run_dir_path);

tests/run-make/doctests-runtool/rmake.rs

+1-2
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,7 @@ fn main() {
2929
.arg(run_dir_name)
3030
.arg("--runtool")
3131
.arg(&run_tool_binary)
32-
.arg("--extern")
33-
.arg("t=libt.rlib")
32+
.extern_("t", "libt.rlib")
3433
.current_dir(tmp_dir())
3534
.run();
3635

+2-4
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
use run_make_support::{rustdoc, tmp_dir};
2-
use std::process::Command;
1+
use run_make_support::{python_command, rustdoc, tmp_dir};
32

43
fn main() {
54
let out_dir = tmp_dir().join("out");
@@ -10,6 +9,5 @@ fn main() {
109
.output(&out_dir)
1110
.run();
1211
// FIXME (GuillaumeGomez): Port the python script to Rust as well.
13-
let python = std::env::var("PYTHON").unwrap_or("python".into());
14-
assert!(Command::new(python).arg("validate_json.py").arg(&out_dir).status().unwrap().success());
12+
assert!(python_command().arg("validate_json.py").arg(&out_dir).status().unwrap().success());
1513
}

0 commit comments

Comments
 (0)