Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit f9ad60c

Browse files
authoredDec 18, 2019
Rollup merge of #67351 - Mark-Simulacrum:always-channel, r=pietroalbini
Set release channel on non-dist builders Toolstate publication only runs if the channel is "nightly" and previously the toolstate builders did not know that the channel was nightly (since they are not dist builders). A look through bootstrap seems to indicate that nothing should directly depend on the channel being set to `-dev` on the test builders, though this may cause some problems with UI tests (if for some reason they're dumping the channel into stderr), but we cannot find evidence of such so hopefully this is fine. r? @pietroalbini
2 parents d6fe88c + f365dbc commit f9ad60c

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed
 

‎src/ci/run.sh

+6-1
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,13 @@ fi
4444
# FIXME: need a scheme for changing this `nightly` value to `beta` and `stable`
4545
# either automatically or manually.
4646
export RUST_RELEASE_CHANNEL=nightly
47+
48+
# Always set the release channel for bootstrap; this is normally not important (i.e., only dist
49+
# builds would seem to matter) but in practice bootstrap wants to know whether we're targeting
50+
# master, beta, or stable with a build to determine whether to run some checks (notably toolstate).
51+
RUST_CONFIGURE_ARGS="$RUST_CONFIGURE_ARGS --release-channel=$RUST_RELEASE_CHANNEL"
52+
4753
if [ "$DEPLOY$DEPLOY_ALT" = "1" ]; then
48-
RUST_CONFIGURE_ARGS="$RUST_CONFIGURE_ARGS --release-channel=$RUST_RELEASE_CHANNEL"
4954
RUST_CONFIGURE_ARGS="$RUST_CONFIGURE_ARGS --enable-llvm-static-stdcpp"
5055
RUST_CONFIGURE_ARGS="$RUST_CONFIGURE_ARGS --set rust.remap-debuginfo"
5156
RUST_CONFIGURE_ARGS="$RUST_CONFIGURE_ARGS --debuginfo-level-std=1"

0 commit comments

Comments
 (0)
Please sign in to comment.