Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit fc36182

Browse files
fmeaseNoratrieb
authored andcommittedJan 14, 2024
Mention label has-merge-commits
1 parent 8042fcc commit fc36182

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed
 

‎src/contributing.md

+7-3
Original file line numberDiff line numberDiff line change
@@ -243,16 +243,20 @@ The CI will also run tidy and will fail if tidy fails.
243243
Rust follows a _no merge-commit policy_, meaning, when you encounter merge
244244
conflicts you are expected to always rebase instead of merging. E.g. always use
245245
rebase when bringing the latest changes from the master branch to your feature
246-
branch.
246+
branch. If your PR contains merge commits, it will get marked as `has-merge-commits`.
247+
Once you have removed the merge commits, e.g., through an interactive rebase, you
248+
should remove the label again:
249+
250+
@rustbot label -has-merge-commits
251+
252+
See [this chapter][labeling] for more details.
247253

248254
If you encounter merge conflicts or when a reviewer asks you to perform some
249255
changes, your PR will get marked as `S-waiting-on-author`. When you resolve
250256
them, you should use `@rustbot` to mark it as `S-waiting-on-review`:
251257

252258
@rustbot label -S-waiting-on-author +S-waiting-on-review
253259

254-
See [this chapter][labeling] for more details.
255-
256260
GitHub allows [closing issues using keywords][closing-keywords]. This feature
257261
should be used to keep the issue tracker tidy. However, it is generally preferred
258262
to put the "closes #123" text in the PR description rather than the issue commit;

0 commit comments

Comments
 (0)
Please sign in to comment.