refresh fixmes

Author: klensy

compiler/rustc_metadata/src/native_libs.rs

@@ -48,6 +48,7 @@ pub fn walk_native_lib_search_dirs<R>(
         f(&sess.target_tlib_path.dir.join("self-contained"), false)?;
     }
 
+    // tidy-keep-sync-with=tidy-ticket-copy_third_party_objects
     // Toolchains for some targets may ship `libunwind.a`, but place it into the main sysroot
     // library directory instead of the self-contained directories.
     // Sanitizer libraries have the same issue and are also linked by name on Apple targets.
@@ -57,7 +58,6 @@ pub fn walk_native_lib_search_dirs<R>(
     // FIXME: On AIX this also has the side-effect of making the list of library search paths
     // non-empty, which is needed or the linker may decide to record the LIBPATH env, if
     // defined, as the search path instead of appending the default search paths.
-    // FIXME: sync me
     if sess.target.vendor == "fortanix"
         || sess.target.os == "linux"
         || sess.target.os == "fuchsia"
@@ -77,6 +77,7 @@ pub fn walk_native_lib_search_dirs<R>(
     }
 
     ControlFlow::Continue(())
+    // tidy-keep-sync-with=tidy-ticket-copy_third_party_objects
 }
 
 pub fn try_find_native_static_library(

compiler/rustc_middle/src/mir/terminator.rs

@@ -135,12 +135,13 @@ impl UnwindAction {
 
 impl UnwindTerminateReason {
     pub fn as_str(self) -> &'static str {
+        // tidy-keep-sync-with=tidy-tidy-ticket-panic-message
         // Keep this in sync with the messages in `core/src/panicking.rs`.
-        // FIXME: sync me
         match self {
             UnwindTerminateReason::Abi => "panic in a function that cannot unwind",
             UnwindTerminateReason::InCleanup => "panic in a destructor during cleanup",
         }
+        // tidy-keep-sync-with=tidy-tidy-ticket-panic-message
     }
 
     /// A short representation of this used for MIR printing.

compiler/rustc_next_trait_solver/src/solve/assembly/structural_traits.rs

@@ -714,9 +714,9 @@ pub(in crate::solve) fn extract_fn_def_from_const_callable<I: Interner>(
     }
 }
 
+// tidy-keep-sync-with=tidy-ticket-evaluate_host_effect_for_destruct_goal
 // NOTE: Keep this in sync with `evaluate_host_effect_for_destruct_goal` in
 // the old solver, for as long as that exists.
-// FIXME: sync me
 pub(in crate::solve) fn const_conditions_for_destruct<I: Interner>(
     cx: I,
     self_ty: I::Ty,
@@ -792,6 +792,7 @@ pub(in crate::solve) fn const_conditions_for_destruct<I: Interner>(
         }
     }
 }
+// tidy-keep-sync-with=tidy-ticket-evaluate_host_effect_for_destruct_goal
 
 /// Assemble a list of predicates that would be present on a theoretical
 /// user impl for an object type. These predicates must be checked any time

compiler/rustc_trait_selection/src/traits/effects.rs

@@ -244,8 +244,8 @@ fn evaluate_host_effect_from_builtin_impls<'tcx>(
     }
 }
 
+// tidy-keep-sync-with=tidy-ticket-evaluate_host_effect_for_destruct_goal
 // NOTE: Keep this in sync with `const_conditions_for_destruct` in the new solver.
-// FIXME: sync me
 fn evaluate_host_effect_for_destruct_goal<'tcx>(
     selcx: &mut SelectionContext<'_, 'tcx>,
     obligation: &HostEffectObligation<'tcx>,
@@ -332,6 +332,7 @@ fn evaluate_host_effect_for_destruct_goal<'tcx>(
         })
         .collect())
 }
+// tidy-keep-sync-with=tidy-ticket-evaluate_host_effect_for_destruct_goal
 
 fn evaluate_host_effect_from_selection_candiate<'tcx>(
     selcx: &mut SelectionContext<'_, 'tcx>,

library/core/src/panicking.rs

@@ -303,9 +303,10 @@ fn panic_misaligned_pointer_dereference(required: usize, found: usize) -> ! {
 #[lang = "panic_cannot_unwind"] // needed by codegen for panic in nounwind function
 #[rustc_nounwind]
 fn panic_cannot_unwind() -> ! {
+    // tidy-keep-sync-with=tidy-ticket-panic-message-nounwind
     // Keep the text in sync with `UnwindTerminateReason::as_str` in `rustc_middle`.
-    // FIXME: sync me
     panic_nounwind("panic in a function that cannot unwind")
+    // tidy-keep-sync-with=tidy-ticket-panic-message-nounwind
 }
 
 /// Panics because we are unwinding out of a destructor during cleanup.
@@ -320,9 +321,10 @@ fn panic_cannot_unwind() -> ! {
 #[lang = "panic_in_cleanup"] // needed by codegen for panic in nounwind function
 #[rustc_nounwind]
 fn panic_in_cleanup() -> ! {
+    // tidy-keep-sync-with=tidy-ticket-panic-message-nobacktrace
     // Keep the text in sync with `UnwindTerminateReason::as_str` in `rustc_middle`.
-    // FIXME: sync me
     panic_nounwind_nobacktrace("panic in a destructor during cleanup")
+    // tidy-keep-sync-with=tidy-ticket-panic-message-nobacktrace
 }
 
 /// This function is used instead of panic_fmt in const eval.

src/bootstrap/src/core/build_steps/compile.rs

@@ -291,6 +291,7 @@ fn copy_llvm_libunwind(builder: &Builder<'_>, target: TargetSelection, libdir: &
     libunwind_target
 }
 
+// tidy-keep-sync-with=tidy-ticket-copy_third_party_objects
 /// Copies third party objects needed by various targets.
 fn copy_third_party_objects(
     builder: &Builder<'_>,
@@ -320,6 +321,7 @@ fn copy_third_party_objects(
 
     target_deps
 }
+// tidy-keep-sync-with=tidy-ticket-copy_third_party_objects
 
 /// Copies third party objects needed by various targets for self-contained linkage.
 fn copy_self_contained_objects(

src/bootstrap/src/core/config/config.rs

@@ -1462,6 +1462,7 @@ impl Config {
             // Allows creating alias for profile names, allowing
             // profiles to be renamed while maintaining back compatibility
             // Keep in sync with `profile_aliases` in bootstrap.py
+            // FIXME: sync me
             let profile_aliases = HashMap::from([("user", "dist")]);
             let include = match profile_aliases.get(include.as_str()) {
                 Some(alias) => alias,

src/bootstrap/src/core/download.rs

@@ -231,6 +231,7 @@ impl Config {
         // options should be kept in sync with
         // src/bootstrap/src/core/download.rs
         // for consistency
+        // FIXME: sync with what?
         let mut curl = command("curl");
         curl.args([
             // follow redirect

src/bootstrap/src/lib.rs

@@ -644,6 +644,8 @@ impl Build {
             features.push("llvm");
         }
         // keep in sync with `bootstrap/compile.rs:rustc_cargo_env`
+        // FIXME: this comment is leftover from https://github.com/rust-lang/rust/pull/93787,
+        // remove it?
         if self.config.rust_randomize_layout {
             features.push("rustc_randomized_layouts");
         }

src/bootstrap/src/utils/render_tests.rs

@@ -167,6 +167,7 @@ impl<'a> Renderer<'a> {
         if let Outcome::Ignored { reason } = outcome {
             self.ignored_tests += 1;
             // Keep this in sync with the "up-to-date" ignore message inserted by compiletest.
+            // FIXME: sync me
             if reason == Some("up-to-date") {
                 self.up_to_date_tests += 1;
             }

src/tools/tidy/src/watcher_list.json

@@ -201,6 +201,56 @@
           "tag": "tidy-ticket-sess-time-item_types_checking"
         }
       ]
+    },
+    {
+      "name": "group_14",
+      "tags": [
+        {
+          "path": "library/core/src/panicking.rs",
+          "hash": "b5387987dd6c927acf5ddfa33fdf3090",
+          "tag": "tidy-ticket-panic-message-nounwind"
+        },
+        {
+          "path": "library/core/src/panicking.rs",
+          "hash": "f07f9a5af83a08e7287cd81226be8834",
+          "tag": "tidy-ticket-panic-message-nobacktrace"
+        },
+        {
+          "path": "compiler/rustc_middle/src/mir/terminator.rs",
+          "hash": "110baa63da1da4d6ae54938b4bbd070f",
+          "tag": "tidy-ticket-panic-message"
+        }
+      ]
+    },
+    {
+      "name": "group_15",
+      "tags": [
+        {
+          "path": "compiler/rustc_next_trait_solver/src/solve/assembly/structural_traits.rs",
+          "hash": "50a549340456169ab3119d1dfecb6f96",
+          "tag": "tidy-ticket-evaluate_host_effect_for_destruct_goal"
+        },
+        {
+          "path": "compiler/rustc_trait_selection/src/traits/effects.rs",
+          "hash": "a280510e2a7424dd874f14ad2180a938",
+          "tag": "tidy-ticket-evaluate_host_effect_for_destruct_goal"
+        }
+      ]
+    },
+    {
+      "name": "group_16",
+      "tags": [
+        {
+          "path": "compiler/rustc_metadata/src/native_libs.rs",
+          "hash": "332941877827af57790ac82c2a40177f",
+          "tag": "tidy-ticket-copy_third_party_objects"
+        },
+        {
+          "path": "src/bootstrap/src/core/build_steps/compile.rs",
+          "hash": "ea843d88787238a509fdc5cb4ad3915b",
+          "tag": "tidy-ticket-copy_third_party_objects"
+        }
+      ]
     }
   ]
 }