Skip to content

Commit fef1026

Browse files
committed
Auto merge of #41308 - eddyb:order-must-be-preserved, r=nagisa
[rustbuild] Side-step HashMap iteration to preserve command-line step order. The new `HashMap` was introduced by #41227 and it accidentally randomized step order. r? @alexcrichton
2 parents 13fd5e9 + c597994 commit fef1026

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/bootstrap/step.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -1217,8 +1217,8 @@ invalid rule dependency graph detected, was a rule added and maybe typo'd?
12171217
let mut visited = HashSet::new();
12181218
visited.insert(0);
12191219
let idx_to_node = nodes.iter().map(|p| (*p.1, p.0)).collect::<HashMap<_, _>>();
1220-
for idx in nodes.values() {
1221-
self.topo_sort(*idx, &idx_to_node, &edges, &mut visited, &mut order);
1220+
for idx in 0..nodes.len() {
1221+
self.topo_sort(idx, &idx_to_node, &edges, &mut visited, &mut order);
12221222
}
12231223
return order
12241224
}

0 commit comments

Comments
 (0)