Skip to content

Commit ffe0836

Browse files
borsbors
committed
Auto merge of #138929 - oli-obk:assoc-ctxt-of-trait, r=<try>
Track whether an assoc item is in a trait impl or an inherent impl `AssocCtxt::Impl` now contains an `of_trait` field. This allows ast lowering and nameres to not have to track whether we're in a trait impl or an inherent impl.
2 parents 7d49ae9 + 59e3380 commit ffe0836

File tree

17 files changed

+185
-96
lines changed

17 files changed

+185
-96
lines changed

‎compiler/rustc_ast/src/mut_visit.rs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1318,7 +1318,9 @@ impl WalkItemKind for ItemKind {
13181318
visit_polarity(vis, polarity);
13191319
visit_opt(of_trait, |trait_ref| vis.visit_trait_ref(trait_ref));
13201320
vis.visit_ty(self_ty);
1321-
items.flat_map_in_place(|item| vis.flat_map_assoc_item(item, AssocCtxt::Impl));
1321+
items.flat_map_in_place(|item| {
1322+
vis.flat_map_assoc_item(item, AssocCtxt::Impl { of_trait: of_trait.is_some() })
1323+
});
13221324
}
13231325
ItemKind::Trait(box Trait { safety, is_auto: _, generics, bounds, items }) => {
13241326
visit_safety(vis, safety);

‎compiler/rustc_ast/src/visit.rs

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ use crate::ptr::P;
2323
#[derive(Copy, Clone, Debug, PartialEq)]
2424
pub enum AssocCtxt {
2525
Trait,
26-
Impl,
26+
Impl { of_trait: bool },
2727
}
2828

2929
#[derive(Copy, Clone, Debug, PartialEq)]
@@ -422,7 +422,12 @@ impl WalkItemKind for ItemKind {
422422
try_visit!(visitor.visit_generics(generics));
423423
visit_opt!(visitor, visit_trait_ref, of_trait);
424424
try_visit!(visitor.visit_ty(self_ty));
425-
walk_list!(visitor, visit_assoc_item, items, AssocCtxt::Impl);
425+
walk_list!(
426+
visitor,
427+
visit_assoc_item,
428+
items,
429+
AssocCtxt::Impl { of_trait: of_trait.is_some() }
430+
);
426431
}
427432
ItemKind::Struct(struct_definition, generics)
428433
| ItemKind::Union(struct_definition, generics) => {

‎compiler/rustc_ast_lowering/src/delegation.rs

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -61,8 +61,14 @@ pub(crate) struct DelegationResults<'hir> {
6161

6262
impl<'hir> LoweringContext<'_, 'hir> {
6363
/// Defines whether the delegatee is an associated function whose first parameter is `self`.
64-
pub(crate) fn delegatee_is_method(&self, item_id: NodeId, path_id: NodeId, span: Span) -> bool {
65-
let sig_id = self.get_delegation_sig_id(item_id, path_id, span);
64+
pub(crate) fn delegatee_is_method(
65+
&self,
66+
item_id: NodeId,
67+
path_id: NodeId,
68+
span: Span,
69+
is_in_trait_impl: bool,
70+
) -> bool {
71+
let sig_id = self.get_delegation_sig_id(item_id, path_id, span, is_in_trait_impl);
6672
let Ok(sig_id) = sig_id else {
6773
return false;
6874
};
@@ -88,9 +94,10 @@ impl<'hir> LoweringContext<'_, 'hir> {
8894
&mut self,
8995
delegation: &Delegation,
9096
item_id: NodeId,
97+
is_in_trait_impl: bool,
9198
) -> DelegationResults<'hir> {
9299
let span = self.lower_span(delegation.path.segments.last().unwrap().ident.span);
93-
let sig_id = self.get_delegation_sig_id(item_id, delegation.id, span);
100+
let sig_id = self.get_delegation_sig_id(item_id, delegation.id, span, is_in_trait_impl);
94101
match sig_id {
95102
Ok(sig_id) => {
96103
let (param_count, c_variadic) = self.param_count(sig_id);
@@ -110,8 +117,9 @@ impl<'hir> LoweringContext<'_, 'hir> {
110117
item_id: NodeId,
111118
path_id: NodeId,
112119
span: Span,
120+
is_in_trait_impl: bool,
113121
) -> Result<DefId, ErrorGuaranteed> {
114-
let sig_id = if self.is_in_trait_impl { item_id } else { path_id };
122+
let sig_id = if is_in_trait_impl { item_id } else { path_id };
115123
self.get_resolution_id(sig_id, span)
116124
}
117125

‎compiler/rustc_ast_lowering/src/item.rs

Lines changed: 27 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ use rustc_hir::def::{DefKind, Res};
77
use rustc_hir::def_id::{CRATE_DEF_ID, LocalDefId};
88
use rustc_hir::{self as hir, HirId, PredicateOrigin};
99
use rustc_index::{IndexSlice, IndexVec};
10-
use rustc_middle::span_bug;
1110
use rustc_middle::ty::{ResolverAstLowering, TyCtxt};
1211
use rustc_span::edit_distance::find_best_match_for_name;
1312
use rustc_span::{DUMMY_SP, DesugaringKind, Ident, Span, Symbol, kw, sym};
@@ -104,10 +103,7 @@ impl<'a, 'hir> ItemLowerer<'a, 'hir> {
104103
}
105104

106105
fn lower_assoc_item(&mut self, item: &AssocItem, ctxt: AssocCtxt) {
107-
let def_id = self.resolver.node_id_to_def_id[&item.id];
108-
let parent_id = self.tcx.local_parent(def_id);
109-
let parent_hir = self.lower_node(parent_id).unwrap();
110-
self.with_lctx(item.id, |lctx| lctx.lower_assoc_item(item, ctxt, parent_hir))
106+
self.with_lctx(item.id, |lctx| lctx.lower_assoc_item(item, ctxt))
111107
}
112108

113109
fn lower_foreign_item(&mut self, item: &ForeignItem) {
@@ -408,10 +404,11 @@ impl<'hir> LoweringContext<'_, 'hir> {
408404
(trait_ref, lowered_ty)
409405
});
410406

411-
self.is_in_trait_impl = trait_ref.is_some();
412-
let new_impl_items = self
413-
.arena
414-
.alloc_from_iter(impl_items.iter().map(|item| self.lower_impl_item_ref(item)));
407+
let new_impl_items = self.arena.alloc_from_iter(
408+
impl_items
409+
.iter()
410+
.map(|item| self.lower_impl_item_ref(item, trait_ref.is_some())),
411+
);
415412

416413
// `defaultness.has_value()` is never called for an `impl`, always `true` in order
417414
// to not cause an assertion failure inside the `lower_defaultness` function.
@@ -488,7 +485,7 @@ impl<'hir> LoweringContext<'_, 'hir> {
488485
ItemKind::Delegation(box delegation) => {
489486
debug_assert_ne!(ident.name, kw::Empty);
490487
let ident = self.lower_ident(ident);
491-
let delegation_results = self.lower_delegation(delegation, id);
488+
let delegation_results = self.lower_delegation(delegation, id, false);
492489
hir::ItemKind::Fn {
493490
ident,
494491
sig: delegation_results.sig,
@@ -631,29 +628,15 @@ impl<'hir> LoweringContext<'_, 'hir> {
631628
}
632629
}
633630

634-
fn lower_assoc_item(
635-
&mut self,
636-
item: &AssocItem,
637-
ctxt: AssocCtxt,
638-
parent_hir: &'hir hir::OwnerInfo<'hir>,
639-
) -> hir::OwnerNode<'hir> {
640-
let parent_item = parent_hir.node().expect_item();
641-
match parent_item.kind {
642-
hir::ItemKind::Impl(impl_) => {
643-
self.is_in_trait_impl = impl_.of_trait.is_some();
644-
}
645-
hir::ItemKind::Trait(..) => {}
646-
kind => {
647-
span_bug!(item.span, "assoc item has unexpected kind of parent: {}", kind.descr())
648-
}
649-
}
650-
631+
fn lower_assoc_item(&mut self, item: &AssocItem, ctxt: AssocCtxt) -> hir::OwnerNode<'hir> {
651632
// Evaluate with the lifetimes in `params` in-scope.
652633
// This is used to track which lifetimes have already been defined,
653634
// and which need to be replicated when lowering an async fn.
654635
match ctxt {
655636
AssocCtxt::Trait => hir::OwnerNode::TraitItem(self.lower_trait_item(item)),
656-
AssocCtxt::Impl => hir::OwnerNode::ImplItem(self.lower_impl_item(item)),
637+
AssocCtxt::Impl { of_trait } => {
638+
hir::OwnerNode::ImplItem(self.lower_impl_item(item, of_trait))
639+
}
657640
}
658641
}
659642

@@ -894,7 +877,7 @@ impl<'hir> LoweringContext<'_, 'hir> {
894877
(generics, kind, ty.is_some())
895878
}
896879
AssocItemKind::Delegation(box delegation) => {
897-
let delegation_results = self.lower_delegation(delegation, i.id);
880+
let delegation_results = self.lower_delegation(delegation, i.id, false);
898881
let item_kind = hir::TraitItemKind::Fn(
899882
delegation_results.sig,
900883
hir::TraitFn::Provided(delegation_results.body_id),
@@ -925,7 +908,7 @@ impl<'hir> LoweringContext<'_, 'hir> {
925908
hir::AssocItemKind::Fn { has_self: sig.decl.has_self() }
926909
}
927910
AssocItemKind::Delegation(box delegation) => hir::AssocItemKind::Fn {
928-
has_self: self.delegatee_is_method(i.id, delegation.id, i.span),
911+
has_self: self.delegatee_is_method(i.id, delegation.id, i.span, false),
929912
},
930913
AssocItemKind::MacCall(..) | AssocItemKind::DelegationMac(..) => {
931914
panic!("macros should have been expanded by now")
@@ -945,7 +928,11 @@ impl<'hir> LoweringContext<'_, 'hir> {
945928
self.expr(span, hir::ExprKind::Err(guar))
946929
}
947930

948-
fn lower_impl_item(&mut self, i: &AssocItem) -> &'hir hir::ImplItem<'hir> {
931+
fn lower_impl_item(
932+
&mut self,
933+
i: &AssocItem,
934+
is_in_trait_impl: bool,
935+
) -> &'hir hir::ImplItem<'hir> {
949936
debug_assert_ne!(i.ident.name, kw::Empty);
950937
// Since `default impl` is not yet implemented, this is always true in impls.
951938
let has_value = true;
@@ -981,7 +968,7 @@ impl<'hir> LoweringContext<'_, 'hir> {
981968
generics,
982969
sig,
983970
i.id,
984-
if self.is_in_trait_impl { FnDeclKind::Impl } else { FnDeclKind::Inherent },
971+
if is_in_trait_impl { FnDeclKind::Impl } else { FnDeclKind::Inherent },
985972
sig.header.coroutine_kind,
986973
attrs,
987974
);
@@ -1021,7 +1008,7 @@ impl<'hir> LoweringContext<'_, 'hir> {
10211008
)
10221009
}
10231010
AssocItemKind::Delegation(box delegation) => {
1024-
let delegation_results = self.lower_delegation(delegation, i.id);
1011+
let delegation_results = self.lower_delegation(delegation, i.id, is_in_trait_impl);
10251012
(
10261013
delegation_results.generics,
10271014
hir::ImplItemKind::Fn(delegation_results.sig, delegation_results.body_id),
@@ -1044,7 +1031,7 @@ impl<'hir> LoweringContext<'_, 'hir> {
10441031
self.arena.alloc(item)
10451032
}
10461033

1047-
fn lower_impl_item_ref(&mut self, i: &AssocItem) -> hir::ImplItemRef {
1034+
fn lower_impl_item_ref(&mut self, i: &AssocItem, is_in_trait_impl: bool) -> hir::ImplItemRef {
10481035
hir::ImplItemRef {
10491036
id: hir::ImplItemId { owner_id: hir::OwnerId { def_id: self.local_def_id(i.id) } },
10501037
ident: self.lower_ident(i.ident),
@@ -1056,7 +1043,12 @@ impl<'hir> LoweringContext<'_, 'hir> {
10561043
hir::AssocItemKind::Fn { has_self: sig.decl.has_self() }
10571044
}
10581045
AssocItemKind::Delegation(box delegation) => hir::AssocItemKind::Fn {
1059-
has_self: self.delegatee_is_method(i.id, delegation.id, i.span),
1046+
has_self: self.delegatee_is_method(
1047+
i.id,
1048+
delegation.id,
1049+
i.span,
1050+
is_in_trait_impl,
1051+
),
10601052
},
10611053
AssocItemKind::MacCall(..) | AssocItemKind::DelegationMac(..) => {
10621054
panic!("macros should have been expanded by now")

‎compiler/rustc_ast_lowering/src/lib.rs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,6 @@ struct LoweringContext<'a, 'hir> {
121121
catch_scope: Option<HirId>,
122122
loop_scope: Option<HirId>,
123123
is_in_loop_condition: bool,
124-
is_in_trait_impl: bool,
125124
is_in_dyn_type: bool,
126125

127126
current_hir_id_owner: hir::OwnerId,
@@ -173,7 +172,6 @@ impl<'a, 'hir> LoweringContext<'a, 'hir> {
173172
catch_scope: None,
174173
loop_scope: None,
175174
is_in_loop_condition: false,
176-
is_in_trait_impl: false,
177175
is_in_dyn_type: false,
178176
coroutine_kind: None,
179177
task_context: None,

‎compiler/rustc_ast_passes/src/ast_validation.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -860,7 +860,7 @@ impl<'a> Visitor<'a> for AstValidator<'a> {
860860
this.visit_trait_ref(t);
861861
this.visit_ty(self_ty);
862862

863-
walk_list!(this, visit_assoc_item, items, AssocCtxt::Impl);
863+
walk_list!(this, visit_assoc_item, items, AssocCtxt::Impl { of_trait: true });
864864
});
865865
walk_list!(self, visit_attribute, &item.attrs);
866866
return; // Avoid visiting again.
@@ -913,7 +913,7 @@ impl<'a> Visitor<'a> for AstValidator<'a> {
913913
|this| this.visit_generics(generics),
914914
);
915915
this.visit_ty(self_ty);
916-
walk_list!(this, visit_assoc_item, items, AssocCtxt::Impl);
916+
walk_list!(this, visit_assoc_item, items, AssocCtxt::Impl { of_trait: false });
917917
});
918918
walk_list!(self, visit_attribute, &item.attrs);
919919
return; // Avoid visiting again.
@@ -1414,7 +1414,7 @@ impl<'a> Visitor<'a> for AstValidator<'a> {
14141414
self.check_defaultness(item.span, item.kind.defaultness());
14151415
}
14161416

1417-
if ctxt == AssocCtxt::Impl {
1417+
if let AssocCtxt::Impl { .. } = ctxt {
14181418
match &item.kind {
14191419
AssocItemKind::Const(box ConstItem { expr: None, .. }) => {
14201420
self.dcx().emit_err(errors::AssocConstWithoutBody {

‎compiler/rustc_builtin_macros/src/autodiff.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,7 @@ mod llvm_enzyme {
157157
};
158158
(sig.clone(), false)
159159
}
160-
Annotatable::AssocItem(assoc_item, _) => {
160+
Annotatable::AssocItem(assoc_item, Impl { of_trait: false }) => {
161161
let sig = match &assoc_item.kind {
162162
ast::AssocItemKind::Fn(box ast::Fn { sig, .. }) => sig,
163163
_ => {
@@ -296,7 +296,7 @@ mod llvm_enzyme {
296296
}
297297
Annotatable::Item(iitem.clone())
298298
}
299-
Annotatable::AssocItem(ref mut assoc_item, i @ Impl) => {
299+
Annotatable::AssocItem(ref mut assoc_item, i @ Impl { of_trait: false }) => {
300300
if !assoc_item.attrs.iter().any(|a| same_attribute(&a.kind, &attr.kind)) {
301301
assoc_item.attrs.push(attr);
302302
}
@@ -327,7 +327,7 @@ mod llvm_enzyme {
327327
kind: assoc_item,
328328
tokens: None,
329329
});
330-
Annotatable::AssocItem(d_fn, Impl)
330+
Annotatable::AssocItem(d_fn, Impl { of_trait: false })
331331
} else {
332332
let mut d_fn =
333333
ecx.item(span, d_ident, thin_vec![d_attr, inline_never], ItemKind::Fn(asdf));

‎compiler/rustc_builtin_macros/src/cfg_eval.rs

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -121,18 +121,11 @@ impl CfgEval<'_> {
121121
let item = parser.parse_item(ForceCollect::Yes)?.unwrap();
122122
Annotatable::Item(self.flat_map_item(item).pop().unwrap())
123123
}
124-
Annotatable::AssocItem(_, AssocCtxt::Trait) => {
124+
Annotatable::AssocItem(_, ctxt) => {
125125
let item = parser.parse_trait_item(ForceCollect::Yes)?.unwrap().unwrap();
126126
Annotatable::AssocItem(
127-
self.flat_map_assoc_item(item, AssocCtxt::Trait).pop().unwrap(),
128-
AssocCtxt::Trait,
129-
)
130-
}
131-
Annotatable::AssocItem(_, AssocCtxt::Impl) => {
132-
let item = parser.parse_impl_item(ForceCollect::Yes)?.unwrap().unwrap();
133-
Annotatable::AssocItem(
134-
self.flat_map_assoc_item(item, AssocCtxt::Impl).pop().unwrap(),
135-
AssocCtxt::Impl,
127+
self.flat_map_assoc_item(item, ctxt).pop().unwrap(),
128+
ctxt,
136129
)
137130
}
138131
Annotatable::ForeignItem(_) => {

‎compiler/rustc_expand/src/base.rs

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ impl Annotatable {
153153

154154
pub fn expect_impl_item(self) -> P<ast::AssocItem> {
155155
match self {
156-
Annotatable::AssocItem(i, AssocCtxt::Impl) => i,
156+
Annotatable::AssocItem(i, AssocCtxt::Impl { .. }) => i,
157157
_ => panic!("expected Item"),
158158
}
159159
}
@@ -403,6 +403,11 @@ pub trait MacResult {
403403
None
404404
}
405405

406+
/// Creates zero or more impl items.
407+
fn make_trait_impl_items(self: Box<Self>) -> Option<SmallVec<[P<ast::AssocItem>; 1]>> {
408+
None
409+
}
410+
406411
/// Creates zero or more trait items.
407412
fn make_trait_items(self: Box<Self>) -> Option<SmallVec<[P<ast::AssocItem>; 1]>> {
408413
None
@@ -516,6 +521,10 @@ impl MacResult for MacEager {
516521
self.impl_items
517522
}
518523

524+
fn make_trait_impl_items(self: Box<Self>) -> Option<SmallVec<[P<ast::AssocItem>; 1]>> {
525+
self.impl_items
526+
}
527+
519528
fn make_trait_items(self: Box<Self>) -> Option<SmallVec<[P<ast::AssocItem>; 1]>> {
520529
self.trait_items
521530
}
@@ -613,6 +622,10 @@ impl MacResult for DummyResult {
613622
Some(SmallVec::new())
614623
}
615624

625+
fn make_trait_impl_items(self: Box<DummyResult>) -> Option<SmallVec<[P<ast::AssocItem>; 1]>> {
626+
Some(SmallVec::new())
627+
}
628+
616629
fn make_trait_items(self: Box<DummyResult>) -> Option<SmallVec<[P<ast::AssocItem>; 1]>> {
617630
Some(SmallVec::new())
618631
}

0 commit comments

Comments
 (0)