Skip to content
Permalink

Comparing changes

This is a direct comparison between two commits made in this repository or its related repositories. View the default comparison for this range or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rust-lang/rust
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: a1e21be2a6679908944b212a2cf84681cbe9dd72
Choose a base ref
..
head repository: rust-lang/rust
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 4b23503b4285f7dd9ee92fd267b3cafaa723a048
Choose a head ref
Showing with 1,606 additions and 1,605 deletions.
  1. +4 −4 src/librustc/hir/check_attr.rs
  2. +9 −9 src/librustc/hir/intravisit.rs
  3. +40 −39 src/librustc/hir/lowering.rs
  4. +12 −17 src/librustc/hir/lowering/expr.rs
  5. +23 −24 src/librustc/hir/lowering/item.rs
  6. +14 −8 src/librustc/hir/map/blocks.rs
  7. +2 −2 src/librustc/hir/map/collector.rs
  8. +10 −10 src/librustc/hir/map/def_collector.rs
  9. +49 −49 src/librustc/hir/map/mod.rs
  10. +14 −14 src/librustc/hir/mod.rs
  11. +7 −7 src/librustc/hir/pat_util.rs
  12. +22 −23 src/librustc/hir/print.rs
  13. +2 −2 src/librustc/hir/upvars.rs
  14. +11 −11 src/librustc/ich/impls_hir.rs
  15. +2 −2 src/librustc/ich/impls_syntax.rs
  16. +5 −5 src/librustc/infer/error_reporting/mod.rs
  17. +3 −3 src/librustc/infer/error_reporting/need_type_info.rs
  18. +4 −4 src/librustc/infer/error_reporting/nice_region_error/find_anon_type.rs
  19. +1 −1 src/librustc/infer/error_reporting/nice_region_error/named_anon_conflict.rs
  20. +1 −1 src/librustc/infer/error_reporting/nice_region_error/outlives_closure.rs
  21. +2 −2 src/librustc/infer/opaque_types/mod.rs
  22. +1 −1 src/librustc/lint/context.rs
  23. +3 −3 src/librustc/lint/internal.rs
  24. +3 −3 src/librustc/lint/levels.rs
  25. +14 −14 src/librustc/middle/dead.rs
  26. +1 −1 src/librustc/middle/entry.rs
  27. +5 −5 src/librustc/middle/expr_use_visitor.rs
  28. +1 −1 src/librustc/middle/intrinsicck.rs
  29. +1 −1 src/librustc/middle/lib_features.rs
  30. +9 −9 src/librustc/middle/liveness.rs
  31. +4 −4 src/librustc/middle/mem_categorization.rs
  32. +13 −13 src/librustc/middle/reachable.rs
  33. +8 −8 src/librustc/middle/region.rs
  34. +32 −33 src/librustc/middle/resolve_lifetime.rs
  35. +5 −5 src/librustc/middle/stability.rs
  36. +2 −2 src/librustc/session/config.rs
  37. +11 −11 src/librustc/traits/error_reporting.rs
  38. +1 −1 src/librustc/traits/util.rs
  39. +3 −3 src/librustc/ty/context.rs
  40. +4 −4 src/librustc/ty/mod.rs
  41. +1 −1 src/librustc_ast_borrowck/borrowck/check_loans.rs
  42. +1 −1 src/librustc_ast_borrowck/borrowck/mod.rs
  43. +3 −3 src/librustc_ast_borrowck/cfg/construct.rs
  44. +2 −2 src/librustc_codegen_llvm/consts.rs
  45. +4 −4 src/librustc_codegen_ssa/back/symbol_export.rs
  46. +1 −1 src/librustc_codegen_ssa/mono_item.rs
  47. +1 −1 src/librustc_driver/lib.rs
  48. +4 −4 src/librustc_incremental/persist/dirty_clean.rs
  49. +8 −8 src/librustc_interface/util.rs
  50. +37 −37 src/librustc_lint/builtin.rs
  51. +9 −9 src/librustc_lint/nonstandard_style.rs
  52. +2 −2 src/librustc_lint/redundant_semicolon.rs
  53. +9 −9 src/librustc_lint/types.rs
  54. +17 −17 src/librustc_lint/unused.rs
  55. +1 −1 src/librustc_metadata/creader.rs
  56. +1 −1 src/librustc_metadata/cstore_impl.rs
  57. +34 −35 src/librustc_metadata/encoder.rs
  58. +1 −1 src/librustc_metadata/foreign_modules.rs
  59. +1 −1 src/librustc_metadata/link_args.rs
  60. +1 −1 src/librustc_metadata/native_libs.rs
  61. +2 −2 src/librustc_mir/borrow_check/conflict_errors.rs
  62. +1 −1 src/librustc_mir/borrow_check/error_reporting.rs
  63. +1 −1 src/librustc_mir/borrow_check/mod.rs
  64. +2 −2 src/librustc_mir/borrow_check/mutability_errors.rs
  65. +6 −6 src/librustc_mir/borrow_check/nll/region_infer/error_reporting/region_name.rs
  66. +1 −1 src/librustc_mir/build/block.rs
  67. +1 −1 src/librustc_mir/build/expr/stmt.rs
  68. +21 −21 src/librustc_mir/build/matches/mod.rs
  69. +11 −11 src/librustc_mir/build/matches/simplify.rs
  70. +39 −39 src/librustc_mir/build/matches/test.rs
  71. +5 −5 src/librustc_mir/build/matches/util.rs
  72. +11 −11 src/librustc_mir/build/mod.rs
  73. +4 −4 src/librustc_mir/hair/cx/block.rs
  74. +4 −4 src/librustc_mir/hair/cx/expr.rs
  75. +2 −5 src/librustc_mir/hair/cx/mod.rs
  76. +6 −6 src/librustc_mir/hair/mod.rs
  77. +89 −91 src/librustc_mir/hair/pattern/_match.rs
  78. +25 −25 src/librustc_mir/hair/pattern/check_match.rs
  79. +166 −166 src/librustc_mir/hair/pattern/mod.rs
  80. +1 −1 src/librustc_mir/interpret/validity.rs
  81. +3 −3 src/librustc_mir/monomorphize/collector.rs
  82. +1 −1 src/librustc_mir/transform/check_unsafety.rs
  83. +1 −1 src/librustc_mir/transform/qualify_consts.rs
  84. +16 −19 src/librustc_passes/ast_validation.rs
  85. +1 −1 src/librustc_passes/layout_test.rs
  86. +2 −2 src/librustc_passes/loops.rs
  87. +5 −5 src/librustc_passes/rvalue_promotion.rs
  88. +1 −1 src/librustc_plugin/build.rs
  89. +18 −18 src/librustc_privacy/lib.rs
  90. +13 −13 src/librustc_resolve/build_reduced_graph.rs
  91. +1 −1 src/librustc_resolve/check_unused.rs
  92. +16 −16 src/librustc_resolve/late.rs
  93. +2 −2 src/librustc_resolve/late/diagnostics.rs
  94. +1 −1 src/librustc_resolve/lib.rs
  95. +12 −12 src/librustc_save_analysis/dump_visitor.rs
  96. +14 −14 src/librustc_save_analysis/lib.rs
  97. +3 −3 src/librustc_save_analysis/sig.rs
  98. +4 −4 src/librustc_traits/lowering/environment.rs
  99. +6 −6 src/librustc_typeck/astconv.rs
  100. +5 −5 src/librustc_typeck/check/_match.rs
  101. +8 −8 src/librustc_typeck/check/callee.rs
  102. +10 −10 src/librustc_typeck/check/compare_method.rs
  103. +16 −16 src/librustc_typeck/check/demand.rs
  104. +5 −5 src/librustc_typeck/check/expr.rs
  105. +1 −1 src/librustc_typeck/check/generator_interior.rs
  106. +2 −2 src/librustc_typeck/check/intrinsic.rs
  107. +2 −2 src/librustc_typeck/check/method/confirm.rs
  108. +4 −4 src/librustc_typeck/check/method/suggest.rs
  109. +43 −43 src/librustc_typeck/check/mod.rs
  110. +8 −8 src/librustc_typeck/check/pat.rs
  111. +3 −3 src/librustc_typeck/check/regionck.rs
  112. +1 −1 src/librustc_typeck/check/upvar.rs
  113. +5 −5 src/librustc_typeck/check/wfcheck.rs
  114. +5 −5 src/librustc_typeck/check/writeback.rs
  115. +2 −2 src/librustc_typeck/check_unused.rs
  116. +4 −4 src/librustc_typeck/coherence/builtin.rs
  117. +1 −1 src/librustc_typeck/coherence/inherent_impls.rs
  118. +1 −1 src/librustc_typeck/coherence/inherent_impls_overlap.rs
  119. +1 −1 src/librustc_typeck/coherence/orphan.rs
  120. +1 −1 src/librustc_typeck/coherence/unsafety.rs
  121. +59 −59 src/librustc_typeck/collect.rs
  122. +2 −2 src/librustc_typeck/impl_wf_check.rs
  123. +2 −2 src/librustc_typeck/lib.rs
  124. +1 −1 src/librustc_typeck/outlives/implicit_infer.rs
  125. +1 −1 src/librustc_typeck/outlives/mod.rs
  126. +4 −4 src/librustc_typeck/variance/constraints.rs
  127. +4 −4 src/librustc_typeck/variance/mod.rs
  128. +4 −4 src/librustc_typeck/variance/terms.rs
  129. +2 −2 src/librustdoc/clean/cfg.rs
  130. +3 −3 src/librustdoc/clean/cfg/tests.rs
  131. +3 −3 src/librustdoc/clean/inline.rs
  132. +11 −11 src/librustdoc/clean/mod.rs
  133. +8 −17 src/librustdoc/clean/simplify.rs
  134. +4 −4 src/librustdoc/test.rs
  135. +3 −3 src/librustdoc/visit_ast.rs
  136. +32 −32 src/libsyntax/ast.rs
  137. +14 −14 src/libsyntax/attr/builtin.rs
  138. +21 −21 src/libsyntax/attr/mod.rs
  139. +3 −3 src/libsyntax/config.rs
  140. +1 −1 src/libsyntax/entry.rs
  141. +10 −10 src/libsyntax/ext/base.rs
  142. +15 −15 src/libsyntax/ext/build.rs
  143. +24 −24 src/libsyntax/ext/expand.rs
  144. +1 −1 src/libsyntax/ext/mbe/macro_rules.rs
  145. +20 −20 src/libsyntax/ext/placeholders.rs
  146. +1 −1 src/libsyntax/ext/proc_macro.rs
  147. +9 −9 src/libsyntax/feature_gate/check.rs
  148. +24 −24 src/libsyntax/mut_visit.rs
  149. +4 −4 src/libsyntax/parse/attr.rs
  150. +1 −1 src/libsyntax/parse/classify.rs
  151. +15 −15 src/libsyntax/parse/diagnostics.rs
  152. +4 −4 src/libsyntax/parse/literal.rs
  153. +1 −1 src/libsyntax/parse/parser.rs
  154. +8 −8 src/libsyntax/parse/parser/expr.rs
  155. +15 −15 src/libsyntax/parse/parser/item.rs
  156. +7 −7 src/libsyntax/parse/parser/pat.rs
  157. +1 −1 src/libsyntax/parse/parser/path.rs
  158. +11 −11 src/libsyntax/parse/parser/stmt.rs
  159. +3 −3 src/libsyntax/parse/parser/ty.rs
  160. +3 −3 src/libsyntax/parse/tests.rs
  161. +38 −41 src/libsyntax/print/pprust.rs
  162. +1 −1 src/libsyntax/util/parser.rs
  163. +8 −8 src/libsyntax/visit.rs
  164. +1 −1 src/libsyntax_ext/asm.rs
  165. +2 −2 src/libsyntax_ext/concat.rs
  166. +2 −2 src/libsyntax_ext/concat_idents.rs
  167. +1 −1 src/libsyntax_ext/deriving/clone.rs
  168. +1 −1 src/libsyntax_ext/deriving/debug.rs
  169. +7 −7 src/libsyntax_ext/deriving/generic/mod.rs
  170. +1 −1 src/libsyntax_ext/global_allocator.rs
  171. +1 −1 src/libsyntax_ext/global_asm.rs
  172. +1 −1 src/libsyntax_ext/plugin_macro_defs.rs
  173. +2 −2 src/libsyntax_ext/proc_macro_harness.rs
  174. +4 −4 src/libsyntax_ext/test.rs
  175. +5 −5 src/libsyntax_ext/test_harness.rs
  176. +16 −0 src/test/rustdoc/auxiliary/issue-57180.rs
  177. +7 −0 src/test/rustdoc/issue-57180.rs
  178. +1 −1 src/test/ui-fulldeps/ast_stmt_expr_attr.rs
  179. +4 −4 src/test/ui-fulldeps/pprust-expr-roundtrip.rs
  180. +1 −1 src/test/ui/ast-json/ast-json-output.stdout
  181. +1 −1 src/tools/clippy
8 changes: 4 additions & 4 deletions src/librustc/hir/check_attr.rs
Original file line number Diff line number Diff line change
@@ -65,7 +65,7 @@ impl Display for Target {

impl Target {
pub(crate) fn from_item(item: &hir::Item) -> Target {
match item.node {
match item.kind {
hir::ItemKind::ExternCrate(..) => Target::ExternCrate,
hir::ItemKind::Use(..) => Target::Use,
hir::ItemKind::Static(..) => Target::Static,
@@ -262,7 +262,7 @@ impl CheckAttrVisitor<'tcx> {

fn check_stmt_attributes(&self, stmt: &hir::Stmt) {
// When checking statements ignore expressions, they will be checked later
if let hir::StmtKind::Local(ref l) = stmt.node {
if let hir::StmtKind::Local(ref l) = stmt.kind {
for attr in l.attrs.iter() {
if attr.check_name(sym::inline) {
self.check_inline(attr, &stmt.span, Target::Statement);
@@ -280,7 +280,7 @@ impl CheckAttrVisitor<'tcx> {
}

fn check_expr_attributes(&self, expr: &hir::Expr) {
let target = match expr.node {
let target = match expr.kind {
hir::ExprKind::Closure(..) => Target::Closure,
_ => Target::Expression,
};
@@ -333,7 +333,7 @@ impl Visitor<'tcx> for CheckAttrVisitor<'tcx> {
}

fn is_c_like_enum(item: &hir::Item) -> bool {
if let hir::ItemKind::Enum(ref def, _) = item.node {
if let hir::ItemKind::Enum(ref def, _) = item.kind {
for variant in &def.variants {
match variant.data {
hir::VariantData::Unit(..) => { /* continue */ }
18 changes: 9 additions & 9 deletions src/librustc/hir/intravisit.rs
Original file line number Diff line number Diff line change
@@ -465,7 +465,7 @@ pub fn walk_param<'v, V: Visitor<'v>>(visitor: &mut V, param: &'v Param) {
pub fn walk_item<'v, V: Visitor<'v>>(visitor: &mut V, item: &'v Item) {
visitor.visit_vis(&item.vis);
visitor.visit_ident(item.ident);
match item.node {
match item.kind {
ItemKind::ExternCrate(orig_name) => {
visitor.visit_id(item.hir_id);
if let Some(orig_name) = orig_name {
@@ -594,7 +594,7 @@ pub fn walk_variant<'v, V: Visitor<'v>>(visitor: &mut V,
pub fn walk_ty<'v, V: Visitor<'v>>(visitor: &mut V, typ: &'v Ty) {
visitor.visit_id(typ.hir_id);

match typ.node {
match typ.kind {
TyKind::Slice(ref ty) => {
visitor.visit_ty(ty)
}
@@ -696,7 +696,7 @@ pub fn walk_assoc_type_binding<'v, V: Visitor<'v>>(visitor: &mut V,

pub fn walk_pat<'v, V: Visitor<'v>>(visitor: &mut V, pattern: &'v Pat) {
visitor.visit_id(pattern.hir_id);
match pattern.node {
match pattern.kind {
PatKind::TupleStruct(ref qpath, ref children, _) => {
visitor.visit_qpath(qpath, pattern.hir_id, pattern.span);
walk_list!(visitor, visit_pat, children);
@@ -743,7 +743,7 @@ pub fn walk_foreign_item<'v, V: Visitor<'v>>(visitor: &mut V, foreign_item: &'v
visitor.visit_vis(&foreign_item.vis);
visitor.visit_ident(foreign_item.ident);

match foreign_item.node {
match foreign_item.kind {
ForeignItemKind::Fn(ref function_declaration, ref param_names, ref generics) => {
visitor.visit_generics(generics);
visitor.visit_fn_decl(function_declaration);
@@ -856,7 +856,7 @@ pub fn walk_trait_item<'v, V: Visitor<'v>>(visitor: &mut V, trait_item: &'v Trai
visitor.visit_ident(trait_item.ident);
walk_list!(visitor, visit_attribute, &trait_item.attrs);
visitor.visit_generics(&trait_item.generics);
match trait_item.node {
match trait_item.kind {
TraitItemKind::Const(ref ty, default) => {
visitor.visit_id(trait_item.hir_id);
visitor.visit_ty(ty);
@@ -905,7 +905,7 @@ pub fn walk_impl_item<'v, V: Visitor<'v>>(visitor: &mut V, impl_item: &'v ImplIt
ref defaultness,
ref attrs,
ref generics,
ref node,
ref kind,
span: _,
} = *impl_item;

@@ -914,7 +914,7 @@ pub fn walk_impl_item<'v, V: Visitor<'v>>(visitor: &mut V, impl_item: &'v ImplIt
visitor.visit_defaultness(defaultness);
walk_list!(visitor, visit_attribute, attrs);
visitor.visit_generics(generics);
match *node {
match *kind {
ImplItemKind::Const(ref ty, body) => {
visitor.visit_id(impl_item.hir_id);
visitor.visit_ty(ty);
@@ -974,7 +974,7 @@ pub fn walk_block<'v, V: Visitor<'v>>(visitor: &mut V, block: &'v Block) {

pub fn walk_stmt<'v, V: Visitor<'v>>(visitor: &mut V, statement: &'v Stmt) {
visitor.visit_id(statement.hir_id);
match statement.node {
match statement.kind {
StmtKind::Local(ref local) => visitor.visit_local(local),
StmtKind::Item(item) => visitor.visit_nested_item(item),
StmtKind::Expr(ref expression) |
@@ -992,7 +992,7 @@ pub fn walk_anon_const<'v, V: Visitor<'v>>(visitor: &mut V, constant: &'v AnonCo
pub fn walk_expr<'v, V: Visitor<'v>>(visitor: &mut V, expression: &'v Expr) {
visitor.visit_id(expression.hir_id);
walk_list!(visitor, visit_attribute, expression.attrs.iter());
match expression.node {
match expression.kind {
ExprKind::Box(ref subexpression) => {
visitor.visit_expr(subexpression)
}
Loading