Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Future-Incompatible Lint - Improve Example #102743

Closed
amab8901 opened this issue Oct 6, 2022 · 1 comment
Closed

Future-Incompatible Lint - Improve Example #102743

amab8901 opened this issue Oct 6, 2022 · 1 comment
Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools

Comments

@amab8901
Copy link
Contributor

amab8901 commented Oct 6, 2022

I was reading about future-incompatible lints on this page.

First of all, I struggled to reproduce the lint warning, and it would have been really educational if you provided an example of how to trigger that lint warning for future incompatibility (please add example of how I can trigger the warning showed in that section).

Second, I tried applying the #![warn(safe_packed_borrows)] in Rust Playground, like this:

#![allow(safe_packed_borrows)]
fn main() {}

Running the code produces, among other things, the following:

warning: lint `safe_packed_borrows` has been renamed to `unaligned_references`

So that means that you should update the "example of what a future-incompatible looks like", because the current example is obsolete.

@amab8901 amab8901 added the A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools label Oct 6, 2022
@Dylan-DPC
Copy link
Member

Closing this because in the pr (#127504) we decided it's better to leave it as is, and is a pain to keep updated and there is less benefit in having the illustrated example not be out of date.

@Dylan-DPC Dylan-DPC closed this as not planned Won't fix, can't repro, duplicate, stale Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants