You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
You'll always be able to craft inputs for rustc making it hit a pathological compile-time and I don't think we need to protect against this. SipHash is pretty fast for strings, but on short fixed-size key types it's very slow. The compiler depends heavily on the speed of looking up integer keys in maps, so this is a huge performance cost.
(I'll post benchmark numbers soon)
The text was updated successfully, but these errors were encountered:
A fast block cipher would also work here, but most are probably even slower than SipHash and are likely all going to be slower than just a multiplication...
You'll always be able to craft inputs for
rustc
making it hit a pathological compile-time and I don't think we need to protect against this. SipHash is pretty fast for strings, but on short fixed-size key types it's very slow. The compiler depends heavily on the speed of looking up integer keys in maps, so this is a huge performance cost.(I'll post benchmark numbers soon)
The text was updated successfully, but these errors were encountered: