Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy should detect unreachable modules in compiler/ #106206

Closed
compiler-errors opened this issue Dec 28, 2022 · 2 comments
Closed

Tidy should detect unreachable modules in compiler/ #106206

compiler-errors opened this issue Dec 28, 2022 · 2 comments
Labels
T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@compiler-errors
Copy link
Member

compiler-errors commented Dec 28, 2022

We shouldn't probably ever have unreachable modules in compiler/, so we should implement a tidy lint against them.

Would've probably caught some super stupid module file duplications that happened due to a failed module rename (twice!!) in 3b9daac, resulting in the clean-up PR: #106205

@clubby789
Copy link
Contributor

@rustbot label +T-bootstrap

@rustbot rustbot added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Mar 27, 2023
@Mark-Simulacrum
Copy link
Member

Ultimately a fix here is very likely to look like #28711, which is a long-standing bug. I'm not sure scoping to just compiler/ helps here.

I think it makes sense to close this in favor of that issue since any implementation ought to at least aim to address the full scope, even if it falls short (as many tidy lints do).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

No branches or pull requests

5 participants