Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dogfood CARGO_REGISTRIES_CRATES_IO_PROTOCOL=sparse in CI #107342

Closed
jyn514 opened this issue Jan 27, 2023 · 0 comments · Fixed by #107543
Closed

Dogfood CARGO_REGISTRIES_CRATES_IO_PROTOCOL=sparse in CI #107342

jyn514 opened this issue Jan 27, 2023 · 0 comments · Fixed by #107543
Assignees
@ehuss
Labels
T-cargo Relevant to the cargo team, which will review and decide on the PR/issue. T-crates-io Relevant to the crates.io team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Comments

@jyn514
Copy link
Member

jyn514 commented Jan 27, 2023

Sparse-registry was recently stabilized and cargo itself has started dogfooding it in CI: rust-lang/cargo#11632. We should do the same in rust-lang/rust, both to speed up CI and to test out the feature.

I think around

rust/src/ci/run.sh

Lines 129 to 130 in beefcf8

export COMPILETEST_NEEDS_ALL_LLVM_COMPONENTS=1
is the right place to set this; we should verify by inspection that the feature is being used in CI before merging.
@jyn514 jyn514 added T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-cargo Relevant to the cargo team, which will review and decide on the PR/issue. T-crates-io Relevant to the crates.io team, which will review and decide on the PR/issue. labels Jan 27, 2023
@ehuss ehuss mentioned this issue Feb 1, 2023
Merged
@bors bors closed this as completed in 5d32458 Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ehuss ehuss

Labels
T-cargo Relevant to the cargo team, which will review and decide on the PR/issue. T-crates-io Relevant to the crates.io team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable Cargo's sparse protocol in CI ehuss/rust
2 participants
@ehuss @jyn514