x clean library/std fails with an unexpected argument error

[clubby789]

x clean library/std invokes cargo clean --target ... --release std, resulting in

error: unexpected argument 'std' found

Usage: cargo clean [OPTIONS]

For more information, try '--help'.

Cleaning a compiler/ crate correctly adds the -p flag needed to specify packages.

I did notice that adding the -p caused the command to complete successfully, but the std build dir was not actually cleaned.

@rustbot label +T-bootstrap

[KittyBorgX]

Does x clean --target library/std help?

Cleaning a compiler/ crate correctly adds the -p flag needed to specify packages.

Unfortunately, that unexpectedly fails on my end:

Building bootstrap
    Finished dev [unoptimized] target(s) in 0.03s
Cleaning {rustc_lexer} stage0 rustc artifacts (aarch64-apple-darwin -> aarch64-apple-darwin)
error: unexpected argument 'rustc_lexer' found

[albertlarsan68]

Here is a (hacky) way to get it working:

diff --git a/src/bootstrap/clean.rs b/src/bootstrap/clean.rs
index 468efc1114c4..7ebd0a8f2706 100644
--- a/src/bootstrap/clean.rs
+++ b/src/bootstrap/clean.rs
@@ -62,6 +62,7 @@ fn run(self, builder: &Builder<'_>) -> Self::Output {
                 let target = compiler.host;
                 let mut cargo = builder.bare_cargo(compiler, $mode, target, "clean");
                 for krate in &*self.crates {
+                    cargo.arg("-p");
                     cargo.arg(krate);
                 }

You can make a PR with this patch, but I am not sure many people are using this way of cleaning, so it may not get much attention.

[clubby789]

Hmm, I must have made a mistake while manually adding -p to the command line. That patch fixes it, thank you 🙂