Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dogfood CARGO_REGISTRIES_CRATES_IO_PROTOCOL=sparse in bootstrap #108766

Closed
jyn514 opened this issue Mar 5, 2023 · 3 comments
Closed

Dogfood CARGO_REGISTRIES_CRATES_IO_PROTOCOL=sparse in bootstrap #108766

jyn514 opened this issue Mar 5, 2023 · 3 comments
Assignees
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@jyn514
Copy link
Member

jyn514 commented Mar 5, 2023

Sparse-registry was recently stabilized and we've started testing it in CI: #107543

It would be nice to also use it when running locally so that compile times are a bit faster (and to increase coverage). The code to change lives somewhere around

cargo.env("RUSTC_INSTALL_BINDIR", self.config.bindir_relative());

We should also undo the changes in #107543 at the same time, since they're now redundant.

@jyn514 jyn514 added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. C-enhancement Category: An issue proposing an enhancement or a PR with one. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Mar 5, 2023
@KittyBorgX
Copy link
Member

@rustbot claim

@albertlarsan68
Copy link
Member

I think there should be a way to opt-out, maybe via an env variable, but it should be discoverable, even though this method will become the default/only.
The benefits will not be that much visible, because the only time it could be needed to update the registry is when first building bootstrap (because the Cargo.{toml, lock} files contain unknown dependencies), or when messing with the dependencies.

@jyn514
Copy link
Member Author

jyn514 commented Mar 6, 2023

I don't want to add more knobs to bootstrap. If we think this is likely to fail we should just wait until cargo turns it on by default.

That said I don't think it's likely to fail, CI has been using it fine for a few weeks.

@jyn514 jyn514 closed this as completed Mar 6, 2023
@jyn514 jyn514 closed this as not planned Won't fix, can't repro, duplicate, stale Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants