Skip to content

feature gate all quasi-quoting macros #11630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
brson opened this issue Jan 18, 2014 · 6 comments · Fixed by #12025
Closed

feature gate all quasi-quoting macros #11630

brson opened this issue Jan 18, 2014 · 6 comments · Fixed by #12025
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Milestone
1.0

Comments

@brson
Copy link
Contributor

brson commented Jan 18, 2014

These all are only useful in the compiler, aren't hygienic, etc. Nominating.
@sfackler
Copy link
Member

What hygiene issues do they still have? The hygiene issue I'm aware of was fixed by #8556. They'll be very useful for externally defined syntax extensions. I'm okay with feature gating it though.

@brson
Copy link
Contributor Author

brson commented Jan 18, 2014

The only thing I recall is that they require an ExtCtxt to be in scope. Perhaps that's not technically a hygiene problem.

@pnkfelix
Copy link
Member

Accepted for 1.0, P-backcompat-lang.

@pnkfelix pnkfelix mentioned this issue Jan 22, 2014
Closed
@lilac
Copy link
Contributor

lilac commented Feb 3, 2014

I would like to look at this, but I am not familiar to quasi-quoting. Can you list some quasi-quoting macros, or point out the directory of the source tree to look up?

What I have found related to quasi-quoting lies on libsyntax/ext/quote.rs.

@sfackler
Copy link
Member

sfackler commented Feb 4, 2014

All of the quasi-quoting macros live there.

@huonw
Copy link
Member

huonw commented Feb 4, 2014

Their names are listed here.

@lilac lilac mentioned this issue Feb 4, 2014
Merged
@bors bors closed this as completed in 53864ce Feb 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

Feature gate all quasi-quoting macros. lilac/rust
5 participants
@brson @pnkfelix @lilac @huonw @sfackler