You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is similar to #118393. If someone figures out how to do one it should be easy to do the other as well.
For a long time, panics from compiler_builtins would result in linker errors unless they happened to be optimized out by the linker before resolution. Since #122580, such calls will either be replaced by a backend's abort intrinsic or a compile error during code generation.
I've used this locally to assess whether the PR fixes the root problem:
This objdump -r | grep is searching for mentions of core in the relocations inside the rlib. If don't find any, then compiler_builtins does not depend on core at link-time. There may be a more fine-tuned way to write this check that would make a test more robust, but this grep is sufficient to validate the property we need.
The text was updated successfully, but these errors were encountered:
This is similar to #118393. If someone figures out how to do one it should be easy to do the other as well.
For a long time, panics from
compiler_builtins
would result in linker errors unless they happened to be optimized out by the linker before resolution. Since #122580, such calls will either be replaced by a backend's abort intrinsic or a compile error during code generation.I've used this locally to assess whether the PR fixes the root problem:
This
objdump -r | grep
is searching for mentions ofcore
in the relocations inside the rlib. If don't find any, thencompiler_builtins
does not depend oncore
at link-time. There may be a more fine-tuned way to write this check that would make a test more robust, but this grep is sufficient to validate the property we need.The text was updated successfully, but these errors were encountered: