Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of Cargo.lock from rust-src causes Bevy CI to fail #128840

Closed
BD103 opened this issue Aug 8, 2024 · 2 comments
Closed

Removal of Cargo.lock from rust-src causes Bevy CI to fail #128840

BD103 opened this issue Aug 8, 2024 · 2 comments
Labels
C-bug Category: This is a bug.

Comments

@BD103
Copy link
Contributor

BD103 commented Aug 8, 2024

Description

As part of Bevy's CI, we check that it builds with wasm32-unknown-unknown with target-feature=+atomics,+bulk-memory on nightly. This check has recently started failing due to #128685. I found this after running cargo-bisect-rustc, whose output can be found below:

cargo-bisect-rustc output

searched nightlies: from nightly-2024-08-06 to nightly-2024-08-08
regressed nightly: nightly-2024-08-08
searched commit range: 60d1465...8b38707
regressed commit: 0ddead3

bisected with cargo-bisect-rustc v0.6.9

Host triple: aarch64-apple-darwin
Reproduce with:

RUSTFLAGS="-C target-feature=+atomics,+bulk-memory" GITHUB_TOKEN=`gh auth token` cargo bisect-rustc --access=github --with-src --start=2024-08-06 --end=2024-08-08 -- check --target wasm32-unknown-unknown -Z build-std=std,panic_abort
@BD103 BD103 added C-bug Category: This is a bug. regression-untriaged Untriaged performance or correctness regression. labels Aug 8, 2024
@rustbot rustbot added I-prioritize Issue: Indicates that prioritization has been requested for this issue. needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Aug 8, 2024
@ChrisDenton
Copy link
Member

This is a Cargo issue and was fixed by rust-lang/cargo#14370

@BD103
Copy link
Contributor Author

BD103 commented Aug 8, 2024

This is a Cargo issue and was fixed by rust-lang/cargo#14370

Wonderful! I'll close this and test it tomorrow!

@BD103 BD103 closed this as not planned Won't fix, can't repro, duplicate, stale Aug 8, 2024
@saethlin saethlin removed I-prioritize Issue: Indicates that prioritization has been requested for this issue. regression-untriaged Untriaged performance or correctness regression. needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug.
Projects
None yet
Development

No branches or pull requests

4 participants