Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Seedable hashmap for testing? #128948

Open
workingjubilee opened this issue Aug 10, 2024 · 2 comments
Open

Seedable hashmap for testing? #128948

workingjubilee opened this issue Aug 10, 2024 · 2 comments
Labels
C-feature-request Category: A feature request, i.e: not implemented / a PR. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Comments

@workingjubilee
Copy link
Member

This is inspired by the many regressions in #128899 that appeared to be "sorting" issues but actually seem to be hashmap issues. It would be nice if we had some way, even if only for unstable/nightly/internal/literally-just-crater usage, to tweak std's hashmap (or just the RNG for it?) so that we could determine if the hashmap's iteration order is the reason a crate's tests are failing.
@workingjubilee workingjubilee added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Aug 10, 2024
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Aug 10, 2024
@ChrisDenton
Copy link
Member

Couldn't this be done with a PR that simply tweaks RandomState and does a crater?

@workingjubilee
Copy link
Member Author

@ChrisDenton Doesn't work if we want to control both "before" and "after" of RandomState.

@saethlin saethlin added C-feature-request Category: A feature request, i.e: not implemented / a PR. and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Aug 11, 2024
@workingjubilee workingjubilee mentioned this issue Aug 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-feature-request Category: A feature request, i.e: not implemented / a PR. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ChrisDenton @saethlin @workingjubilee @rustbot