Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove std.dll from dist archives on Windows #131587

Open
Kobzol opened this issue Oct 12, 2024 · 0 comments
Open

Remove std.dll from dist archives on Windows #131587

Kobzol opened this issue Oct 12, 2024 · 0 comments
Labels
A-incr-comp Area: Incremental compilation A-testsuite Area: The testsuite used to check the correctness of rustc O-windows Operating system: Windows T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@Kobzol
Copy link
Contributor

Kobzol commented Oct 12, 2024

Thanks to #122362, librustc_driver.so no longer dynamically links to the standard library (libstd.so). And since #131188, we no longer ship the dynamic libstd file on non-Windows platforms. This reduces the size of the dist rustup components that we ship.

However, we still ship std.dll on Windows, because removing it was causing incremental tests to fail in the post-optimization testing done by the opt-dist tool. More information can be found here.

@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Oct 12, 2024
@saethlin saethlin added A-testsuite Area: The testsuite used to check the correctness of rustc O-windows Operating system: Windows T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. A-incr-comp Area: Incremental compilation and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-incr-comp Area: Incremental compilation A-testsuite Area: The testsuite used to check the correctness of rustc O-windows Operating system: Windows T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

3 participants