Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"single tab mode" for rustdoc search #132110

Open
lolbinarycat opened this issue Oct 24, 2024 · 7 comments
Open

"single tab mode" for rustdoc search #132110

lolbinarycat opened this issue Oct 24, 2024 · 7 comments
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Comments

@lolbinarycat
Copy link
Contributor

currently, when performing a single-element search (i.e. a name-based search), there are 3 tabs:

  1. In Names
  2. In Parameters
  3. In Return Types

I basically never use the other two, instead explicitly using type-based search with -> if i want that info.

These extra tabs add visual clutter and also slow down the searching process.

I propose an option in the settings panel to disable these extra tabs.

related: #131156

@lolbinarycat lolbinarycat added C-enhancement Category: An issue proposing an enhancement or a PR with one. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Oct 24, 2024
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Oct 24, 2024
@GuillaumeGomez
Copy link
Member

If you don't use them, why is it an issue if they're present?

@lolbinarycat
Copy link
Contributor Author

These extra tabs add visual clutter and also slow down the searching process.

performance is the main concern, since you're doing nearly 3x as much for every function item. more details are available in the related issue.

@GuillaumeGomez
Copy link
Member

Considering how heavily this feature is used, I think it'd be more of a bother to add yet another setting to disable it.

@lolbinarycat
Copy link
Contributor Author

Considering how heavily this feature is used

is it?

@GuillaumeGomez
Copy link
Member

Yep.

@lqd
Copy link
Member

lqd commented Oct 24, 2024

I personally use it very often when looking at the compiler documentation for example

@jieyouxu jieyouxu removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Oct 24, 2024
@jieyouxu
Copy link
Member

+1 I don't think it makes sense to add another option just to disable those, I personally use the param-pos and ret-type tabs quite often.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.
Projects
None yet
Development

No branches or pull requests

5 participants